Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-03 Thread Igor Mammedov
On Fri, 4 Nov 2016 01:39:31 +0800 Xiao Guangrong wrote: > > > On 11/04/2016 01:29 AM, Igor Mammedov wrote: > > On Fri, 4 Nov 2016 00:53:06 +0800 > > Xiao Guangrong wrote: > > > >> > >> > >> On 11/04/2016 12:49 AM, Igor Mammedov wrote: > >>> On Fri, 4 Nov 2016 00:17:00 +0800 > >>> Xiao Guangron

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-03 Thread Xiao Guangrong
On 11/04/2016 01:29 AM, Igor Mammedov wrote: On Fri, 4 Nov 2016 00:53:06 +0800 Xiao Guangrong wrote: On 11/04/2016 12:49 AM, Igor Mammedov wrote: On Fri, 4 Nov 2016 00:17:00 +0800 Xiao Guangrong wrote: On 11/04/2016 12:13 AM, Igor Mammedov wrote: On Thu, 3 Nov 2016 22:53:43 +0800 Xi

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-03 Thread Igor Mammedov
On Fri, 4 Nov 2016 00:53:06 +0800 Xiao Guangrong wrote: > > > On 11/04/2016 12:49 AM, Igor Mammedov wrote: > > On Fri, 4 Nov 2016 00:17:00 +0800 > > Xiao Guangrong wrote: > > > >> > >> > >> On 11/04/2016 12:13 AM, Igor Mammedov wrote: > >>> On Thu, 3 Nov 2016 22:53:43 +0800 > >>> Xiao Guangron

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-03 Thread Xiao Guangrong
On 11/04/2016 12:49 AM, Igor Mammedov wrote: On Fri, 4 Nov 2016 00:17:00 +0800 Xiao Guangrong wrote: On 11/04/2016 12:13 AM, Igor Mammedov wrote: On Thu, 3 Nov 2016 22:53:43 +0800 Xiao Guangrong wrote: On 11/03/2016 10:49 PM, Igor Mammedov wrote: On Thu, 3 Nov 2016 21:02:22 +0800 Xi

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-03 Thread Igor Mammedov
On Fri, 4 Nov 2016 00:17:00 +0800 Xiao Guangrong wrote: > > > On 11/04/2016 12:13 AM, Igor Mammedov wrote: > > On Thu, 3 Nov 2016 22:53:43 +0800 > > Xiao Guangrong wrote: > > > >> > >> > >> On 11/03/2016 10:49 PM, Igor Mammedov wrote: > >>> On Thu, 3 Nov 2016 21:02:22 +0800 > >>> Xiao Guangron

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-03 Thread Xiao Guangrong
On 11/04/2016 12:13 AM, Igor Mammedov wrote: On Thu, 3 Nov 2016 22:53:43 +0800 Xiao Guangrong wrote: On 11/03/2016 10:49 PM, Igor Mammedov wrote: On Thu, 3 Nov 2016 21:02:22 +0800 Xiao Guangrong wrote: On 11/03/2016 09:00 PM, Igor Mammedov wrote: just drop this and describe prop

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-03 Thread Igor Mammedov
On Thu, 3 Nov 2016 22:53:43 +0800 Xiao Guangrong wrote: > > > On 11/03/2016 10:49 PM, Igor Mammedov wrote: > > On Thu, 3 Nov 2016 21:02:22 +0800 > > Xiao Guangrong wrote: > > > >> > >> > >> On 11/03/2016 09:00 PM, Igor Mammedov wrote: > >> > >> > >> > >> > > just drop this and describe pro

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-03 Thread Xiao Guangrong
On 11/03/2016 10:49 PM, Igor Mammedov wrote: On Thu, 3 Nov 2016 21:02:22 +0800 Xiao Guangrong wrote: On 11/03/2016 09:00 PM, Igor Mammedov wrote: just drop this and describe properly 'len' in spec section i.e. len: length of entire returned data (including the header) Okay, i will c

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-03 Thread Igor Mammedov
On Thu, 3 Nov 2016 21:02:22 +0800 Xiao Guangrong wrote: > > > On 11/03/2016 09:00 PM, Igor Mammedov wrote: > > > > > >>> just drop this and describe properly 'len' in spec section > >>> i.e. len: length of entire returned data (including the header) > >> > >> Okay, i will change the spec li

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-03 Thread Xiao Guangrong
On 11/03/2016 09:00 PM, Igor Mammedov wrote: just drop this and describe properly 'len' in spec section i.e. len: length of entire returned data (including the header) Okay, i will change the spec like this: QEMU Writes Output Data (based on the offset in the page): [0x0 - 0x3]:

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-03 Thread Igor Mammedov
On Thu, 3 Nov 2016 20:21:05 +0800 Xiao Guangrong wrote: > On 11/03/2016 07:58 PM, Igor Mammedov wrote: > > On Thu, 3 Nov 2016 11:51:29 +0800 > > Xiao Guangrong wrote: > > > >> _FIT is required for hotplug support, guest will inquire the updated > >> device info from it if a hotplug event is r

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-03 Thread Igor Mammedov
On Thu, 3 Nov 2016 18:08:04 +0800 Xiao Guangrong wrote: > On 11/03/2016 05:53 PM, Stefan Hajnoczi wrote: > > On Thu, Nov 03, 2016 at 11:51:29AM +0800, Xiao Guangrong wrote: > >> @@ -504,6 +521,77 @@ nvdimm_dsm_no_payload(uint32_t func_ret_status, > >> hwaddr dsm_mem_addr) > >> cpu_physica

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-03 Thread Xiao Guangrong
On 11/03/2016 07:58 PM, Igor Mammedov wrote: On Thu, 3 Nov 2016 11:51:29 +0800 Xiao Guangrong wrote: _FIT is required for hotplug support, guest will inquire the updated device info from it if a hotplug event is received s/_FIT/_FIT method/ the same applies to subj. line Okay. As F

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-03 Thread Igor Mammedov
On Thu, 3 Nov 2016 11:51:29 +0800 Xiao Guangrong wrote: > _FIT is required for hotplug support, guest will inquire the updated > device info from it if a hotplug event is received s/_FIT/_FIT method/ the same applies to subj. line > > As FIT buffer is not completely mapped into guest address

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-03 Thread Xiao Guangrong
On 11/03/2016 05:53 PM, Stefan Hajnoczi wrote: On Thu, Nov 03, 2016 at 11:51:29AM +0800, Xiao Guangrong wrote: @@ -504,6 +521,77 @@ nvdimm_dsm_no_payload(uint32_t func_ret_status, hwaddr dsm_mem_addr) cpu_physical_memory_write(dsm_mem_addr, &out, sizeof(out)); } +#define NVDIMM_DSM_RET

Re: [Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-03 Thread Stefan Hajnoczi
On Thu, Nov 03, 2016 at 11:51:29AM +0800, Xiao Guangrong wrote: > @@ -504,6 +521,77 @@ nvdimm_dsm_no_payload(uint32_t func_ret_status, hwaddr > dsm_mem_addr) > cpu_physical_memory_write(dsm_mem_addr, &out, sizeof(out)); > } > > +#define NVDIMM_DSM_RET_STATUS_SUCCESS0 /* Success */

[Qemu-devel] [PATCH v4 2/3] nvdimm acpi: introduce _FIT

2016-11-02 Thread Xiao Guangrong
_FIT is required for hotplug support, guest will inquire the updated device info from it if a hotplug event is received As FIT buffer is not completely mapped into guest address space, so a new function, Read FIT whose UUID is UUID 648B9CF2-CDA1-4312-8AD9-49C4AF32BD62, handle 0x1, function ind