Re: [Qemu-devel] [PATCH v4 2/3] qemu-img: rebase: Reduce reads on in-chain rebase

2019-05-23 Thread Sam Eiderman
Yes, my bad, resending as v5. Sam > On 23 May 2019, at 19:14, Max Reitz wrote: > > On 23.05.19 17:44, Sam Eiderman wrote: >> In the following case: >> >> (base) A <- B <- C (tip) >> >> when running: >> >>qemu-img rebase -b A C >> >> QEMU would read all sectors not allocated in the file

Re: [Qemu-devel] [PATCH v4 2/3] qemu-img: rebase: Reduce reads on in-chain rebase

2019-05-23 Thread Max Reitz
On 23.05.19 17:44, Sam Eiderman wrote: > In the following case: > > (base) A <- B <- C (tip) > > when running: > > qemu-img rebase -b A C > > QEMU would read all sectors not allocated in the file being rebased (C) > and compare them to the new base image (A), regardless of whether they > we

[Qemu-devel] [PATCH v4 2/3] qemu-img: rebase: Reduce reads on in-chain rebase

2019-05-23 Thread Sam Eiderman
In the following case: (base) A <- B <- C (tip) when running: qemu-img rebase -b A C QEMU would read all sectors not allocated in the file being rebased (C) and compare them to the new base image (A), regardless of whether they were changed or even allocated anywhere along the chain between