Re: [Qemu-devel] [PATCH v4 2/3] utils: Add helper to read arm MIDR_EL1 register

2016-11-04 Thread Peter Maydell
On 4 November 2016 at 14:54, Vijay Kilari wrote: > What do you suggest for this?. Some general principles: * be consistent * don't check things you don't need to * prefer functions that exist in all configs (which may be dummy functions in some cases) rather than guarding callsites and #

Re: [Qemu-devel] [PATCH v4 2/3] utils: Add helper to read arm MIDR_EL1 register

2016-11-04 Thread Vijay Kilari
Hi Peter On Fri, Oct 28, 2016 at 3:39 PM, Vijay Kilari wrote: > On Fri, Oct 28, 2016 at 2:33 PM, Peter Maydell > wrote: >> On 28 October 2016 at 08:00, Vijay Kilari wrote: >>> On Thu, Oct 27, 2016 at 9:33 PM, Peter Maydell >>> wrote: On 25 October 2016 at 13:12, wrote: > From: Vij

Re: [Qemu-devel] [PATCH v4 2/3] utils: Add helper to read arm MIDR_EL1 register

2016-10-28 Thread Vijay Kilari
On Fri, Oct 28, 2016 at 2:33 PM, Peter Maydell wrote: > On 28 October 2016 at 08:00, Vijay Kilari wrote: >> On Thu, Oct 27, 2016 at 9:33 PM, Peter Maydell >> wrote: >>> On 25 October 2016 at 13:12, wrote: From: Vijaya Kumar K Add helper API to read MIDR_EL1 registers to fetch

Re: [Qemu-devel] [PATCH v4 2/3] utils: Add helper to read arm MIDR_EL1 register

2016-10-28 Thread Peter Maydell
On 28 October 2016 at 08:00, Vijay Kilari wrote: > On Thu, Oct 27, 2016 at 9:33 PM, Peter Maydell > wrote: >> On 25 October 2016 at 13:12, wrote: >>> From: Vijaya Kumar K >>> >>> Add helper API to read MIDR_EL1 registers to fetch >>> cpu identification information. This helps in >>> adding er

Re: [Qemu-devel] [PATCH v4 2/3] utils: Add helper to read arm MIDR_EL1 register

2016-10-28 Thread Vijay Kilari
On Thu, Oct 27, 2016 at 9:33 PM, Peter Maydell wrote: > On 25 October 2016 at 13:12, wrote: >> From: Vijaya Kumar K >> >> Add helper API to read MIDR_EL1 registers to fetch >> cpu identification information. This helps in >> adding errata's and architecture specific features. >> >> This is impl

Re: [Qemu-devel] [PATCH v4 2/3] utils: Add helper to read arm MIDR_EL1 register

2016-10-27 Thread Peter Maydell
On 25 October 2016 at 13:12, wrote: > From: Vijaya Kumar K > > Add helper API to read MIDR_EL1 registers to fetch > cpu identification information. This helps in > adding errata's and architecture specific features. > > This is implemented only for arm architecture. > > Signed-off-by: Vijaya Kum