Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

2016-06-22 Thread Laszlo Ersek
On 06/22/16 12:18, Haozhong Zhang wrote: > On 06/17/16 19:31, Laszlo Ersek wrote: >> Hi Haozhong, >> >> On 06/16/16 13:19, Haozhong Zhang wrote: >>> On 06/16/16 11:52, Paolo Bonzini wrote: > [..] Have you prepared a patch for SeaBIOS already? >>> >>> Yes, I'll send it after I fix the type

Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

2016-06-22 Thread Haozhong Zhang
On 06/17/16 19:31, Laszlo Ersek wrote: > Hi Haozhong, > > On 06/16/16 13:19, Haozhong Zhang wrote: > > On 06/16/16 11:52, Paolo Bonzini wrote: [..] > >> Have you prepared a patch for SeaBIOS already? > > > > Yes, I'll send it after I fix the type error (uint32_t => uint64_t) in > > next version.

Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

2016-06-20 Thread Haozhong Zhang
On 06/20/16 08:56, Paolo Bonzini wrote: > > > On 20/06/2016 05:09, Haozhong Zhang wrote: > > In the current nested VMX implementation in QEMU, setup > > MSR_IA32_FEATURE_CONTROL is left to guest. So I think, for LMCE which > > is another feature involving MSR_IA32_FEATURE_CONTROL, we may follow

Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

2016-06-20 Thread Paolo Bonzini
On 20/06/2016 05:09, Haozhong Zhang wrote: > In the current nested VMX implementation in QEMU, setup > MSR_IA32_FEATURE_CONTROL is left to guest. So I think, for LMCE which > is another feature involving MSR_IA32_FEATURE_CONTROL, we may follow > the existing code. > > Paolo and Radim, is there

Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

2016-06-19 Thread Haozhong Zhang
On 06/17/16 13:21, Raj, Ashok wrote: > On Fri, Jun 17, 2016 at 07:31:08PM +0200, Laszlo Ersek wrote: > > >> > > >> On 16/06/2016 08:06, Haozhong Zhang wrote: > > >>> It's a prerequisite that certain bits of MSR_IA32_FEATURE_CONTROL should > > >>> be set before some features (e.g. VMX and LMCE) can

Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

2016-06-17 Thread Laszlo Ersek
On 06/17/16 22:55, Raj, Ashok wrote: > On Fri, Jun 17, 2016 at 10:48:17PM +0200, Laszlo Ersek wrote: >> On 06/17/16 22:21, Raj, Ashok wrote: >>> On Fri, Jun 17, 2016 at 07:31:08PM +0200, Laszlo Ersek wrote: >> >> On 16/06/2016 08:06, Haozhong Zhang wrote: >>> It's a prerequisite that

Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

2016-06-17 Thread Raj, Ashok
On Fri, Jun 17, 2016 at 10:48:17PM +0200, Laszlo Ersek wrote: > On 06/17/16 22:21, Raj, Ashok wrote: > > On Fri, Jun 17, 2016 at 07:31:08PM +0200, Laszlo Ersek wrote: > > On 16/06/2016 08:06, Haozhong Zhang wrote: > > It's a prerequisite that certain bits of MSR_IA32_FEATURE_CONTROL

Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

2016-06-17 Thread Laszlo Ersek
On 06/17/16 22:21, Raj, Ashok wrote: > On Fri, Jun 17, 2016 at 07:31:08PM +0200, Laszlo Ersek wrote: On 16/06/2016 08:06, Haozhong Zhang wrote: > It's a prerequisite that certain bits of MSR_IA32_FEATURE_CONTROL should > be set before some features (e.g. VMX and LMCE) can be

Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

2016-06-17 Thread Raj, Ashok
On Fri, Jun 17, 2016 at 07:31:08PM +0200, Laszlo Ersek wrote: > >> > >> On 16/06/2016 08:06, Haozhong Zhang wrote: > >>> It's a prerequisite that certain bits of MSR_IA32_FEATURE_CONTROL should > >>> be set before some features (e.g. VMX and LMCE) can be used, which is > >>> usually done by the

Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

2016-06-17 Thread Laszlo Ersek
Hi Haozhong, On 06/16/16 13:19, Haozhong Zhang wrote: > On 06/16/16 11:52, Paolo Bonzini wrote: >> >> >> On 16/06/2016 08:06, Haozhong Zhang wrote: >>> It's a prerequisite that certain bits of MSR_IA32_FEATURE_CONTROL should >>> be set before some features (e.g. VMX and LMCE) can be used, which

Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

2016-06-16 Thread Haozhong Zhang
On 06/16/16 11:52, Paolo Bonzini wrote: > > > On 16/06/2016 08:06, Haozhong Zhang wrote: > > It's a prerequisite that certain bits of MSR_IA32_FEATURE_CONTROL should > > be set before some features (e.g. VMX and LMCE) can be used, which is > > usually done by the firmware. This patch adds a

Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

2016-06-16 Thread Paolo Bonzini
On 16/06/2016 08:06, Haozhong Zhang wrote: > It's a prerequisite that certain bits of MSR_IA32_FEATURE_CONTROL should > be set before some features (e.g. VMX and LMCE) can be used, which is > usually done by the firmware. This patch adds a fw_cfg file > "etc/msr_feature_control" which contains

[Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

2016-06-16 Thread Haozhong Zhang
It's a prerequisite that certain bits of MSR_IA32_FEATURE_CONTROL should be set before some features (e.g. VMX and LMCE) can be used, which is usually done by the firmware. This patch adds a fw_cfg file "etc/msr_feature_control" which contains the advised value of MSR_IA32_FEATURE_CONTROL and can