Re: [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-12-03 Thread Fam Zheng
On 2013年12月03日 14:05, Wenchao Xia wrote: Why forbid mode = writeback? These test cases used to run with only possibly writethrough, or none. And they don't work with writeback, at least in my case. So I didn't add other modes here. Fam

Re: [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-12-03 Thread Stefan Hajnoczi
On Tue, Dec 03, 2013 at 02:05:32PM +0800, Wenchao Xia wrote: This patch override only when default is specified, I am +1 with it. I think we had discuss before, just want a double check, stefan, do you agree with this? Yes, I'm happy with this. I just want to avoid test cases with custom code

Re: [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-12-03 Thread Kevin Wolf
Am 03.12.2013 um 09:21 hat Fam Zheng geschrieben: On 2013年12月03日 14:05, Wenchao Xia wrote: Why forbid mode = writeback? These test cases used to run with only possibly writethrough, or none. And they don't work with writeback, at least in my case. So I didn't add other modes

Re: [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-12-03 Thread Fam Zheng
On 2013年12月03日 17:28, Kevin Wolf wrote: Am 03.12.2013 um 09:21 hat Fam Zheng geschrieben: On 2013年12月03日 14:05, Wenchao Xia wrote: Why forbid mode = writeback? These test cases used to run with only possibly writethrough, or none. And they don't work with writeback, at least in my

Re: [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-12-02 Thread Wenchao Xia
This patch override only when default is specified, I am +1 with it. I think we had discuss before, just want a double check, stefan, do you agree with this? This replaces _unsupported_qemu_io_options and check for support of current cache mode, and allow to provide a default if user didn't

[Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-11-25 Thread Fam Zheng
This replaces _unsupported_qemu_io_options and check for support of current cache mode, and allow to provide a default if user didn't specify. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/026 | 3 ++- tests/qemu-iotests/039 | 3 ++- tests/qemu-iotests/052 |