Re: [Qemu-devel] [PATCH v4 3/8] fw_cfg: introduce the "data_memwidth" property

2014-12-16 Thread Laszlo Ersek
On 12/16/14 18:20, Alexander Graf wrote: > On 12/16/14 18:10, Peter Maydell wrote: >> On 16 December 2014 at 16:59, Laszlo Ersek wrote: >>> To elaborate on the above -- the fw_cfg device appears to be >>> undestructible at the moment. It has no unrealize callback. If it were >>> destructible, then

Re: [Qemu-devel] [PATCH v4 3/8] fw_cfg: introduce the "data_memwidth" property

2014-12-16 Thread Alexander Graf
On 12/16/14 18:10, Peter Maydell wrote: On 16 December 2014 at 16:59, Laszlo Ersek wrote: To elaborate on the above -- the fw_cfg device appears to be undestructible at the moment. It has no unrealize callback. If it were destructible, then the above leak would be the smallest of concerns -- it

Re: [Qemu-devel] [PATCH v4 3/8] fw_cfg: introduce the "data_memwidth" property

2014-12-16 Thread Peter Maydell
On 16 December 2014 at 16:59, Laszlo Ersek wrote: > To elaborate on the above -- the fw_cfg device appears to be > undestructible at the moment. It has no unrealize callback. If it were > destructible, then the above leak would be the smallest of concerns -- > it doesn't unmap nor destroy the memo

Re: [Qemu-devel] [PATCH v4 3/8] fw_cfg: introduce the "data_memwidth" property

2014-12-16 Thread Laszlo Ersek
On 12/16/14 13:42, Laszlo Ersek wrote: > On 12/16/14 13:06, Alexander Graf wrote: >> >> >> On 12.12.14 16:58, Laszlo Ersek wrote: >>> The "data_memwidth" property is capable of changing the maximum valid >>> access size to the MMIO data register, and (corresponding to the previous >>> patch) resize

Re: [Qemu-devel] [PATCH v4 3/8] fw_cfg: introduce the "data_memwidth" property

2014-12-16 Thread Laszlo Ersek
On 12/16/14 13:06, Alexander Graf wrote: > > > On 12.12.14 16:58, Laszlo Ersek wrote: >> The "data_memwidth" property is capable of changing the maximum valid >> access size to the MMIO data register, and (corresponding to the previous >> patch) resizes the memory region similarly, at device real

Re: [Qemu-devel] [PATCH v4 3/8] fw_cfg: introduce the "data_memwidth" property

2014-12-16 Thread Alexander Graf
On 12.12.14 16:58, Laszlo Ersek wrote: > The "data_memwidth" property is capable of changing the maximum valid > access size to the MMIO data register, and (corresponding to the previous > patch) resizes the memory region similarly, at device realization time. > > (Because "data_iomem" is config

[Qemu-devel] [PATCH v4 3/8] fw_cfg: introduce the "data_memwidth" property

2014-12-12 Thread Laszlo Ersek
The "data_memwidth" property is capable of changing the maximum valid access size to the MMIO data register, and (corresponding to the previous patch) resizes the memory region similarly, at device realization time. (Because "data_iomem" is configured and installed dynamically now, we must delay t