Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-06-09 Thread Greg Kurz
On Fri, 9 Jun 2017 11:13:50 +0200 Pradeep Jagadeesh wrote: > On 6/9/2017 11:07 AM, Greg Kurz wrote: > > GEN qmp-commands.h > > /tmp/qemu-test/src/qapi-schema.json:85: No such file or directory: > > qapi/fsdev.json > > Makefile:438: recipe for target 'qmp-commands.h' failed > > > > Please f

Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-06-09 Thread Pradeep Jagadeesh
On 6/9/2017 11:07 AM, Greg Kurz wrote: GEN qmp-commands.h /tmp/qemu-test/src/qapi-schema.json:85: No such file or directory: qapi/fsdev.json Makefile:438: recipe for target 'qmp-commands.h' failed Please fix that. Ho ok, I will have a look. How are you trying to compile, using "make dock

Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-06-09 Thread Greg Kurz
On Fri, 9 Jun 2017 10:31:58 +0200 Pradeep Jagadeesh wrote: > On 6/8/2017 6:49 PM, Greg Kurz wrote: > > On Thu, 18 May 2017 15:30:06 +0200 > > Pradeep Jagadeesh wrote: > > > >> On 5/17/2017 7:09 PM, Eric Blake wrote: > >>> On 05/17/2017 11:29 AM, Greg Kurz wrote: > >>> > > > > First

Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-06-09 Thread Pradeep Jagadeesh
On 6/8/2017 6:49 PM, Greg Kurz wrote: On Thu, 18 May 2017 15:30:06 +0200 Pradeep Jagadeesh wrote: On 5/17/2017 7:09 PM, Eric Blake wrote: On 05/17/2017 11:29 AM, Greg Kurz wrote: First point: is fsdev a Linux-only feature, or can it be compiled on BSD? If it is Linux-only, then compiling

Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-06-08 Thread Greg Kurz
On Thu, 18 May 2017 15:30:06 +0200 Pradeep Jagadeesh wrote: > On 5/17/2017 7:09 PM, Eric Blake wrote: > > On 05/17/2017 11:29 AM, Greg Kurz wrote: > > > >>> > >>> First point: is fsdev a Linux-only feature, or can it be compiled on > >>> BSD? If it is Linux-only, then compiling a stub for Wind

Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-05-18 Thread Pradeep Jagadeesh
On 5/17/2017 7:09 PM, Eric Blake wrote: On 05/17/2017 11:29 AM, Greg Kurz wrote: First point: is fsdev a Linux-only feature, or can it be compiled on BSD? If it is Linux-only, then compiling a stub for Windows will still leave BSD broken, and your #ifdef is wrong. Fixing compilation on mingw

Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-05-17 Thread Eric Blake
On 05/17/2017 11:29 AM, Greg Kurz wrote: >> >> First point: is fsdev a Linux-only feature, or can it be compiled on >> BSD? If it is Linux-only, then compiling a stub for Windows will still >> leave BSD broken, and your #ifdef is wrong. Fixing compilation on mingw >> is nice, but not the only pl

Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-05-17 Thread Greg Kurz
On Wed, 17 May 2017 10:28:33 -0500 Eric Blake wrote: > On 05/17/2017 09:53 AM, Pradeep Jagadeesh wrote: > > >>> +#ifdef _WIN64 > >>> + > >>> +void qmp_fsdev_set_io_throttle(IOThrottle *arg, Error **errp) > >>> +{ > >>> + return; > >>> +} > >>> + > >>> +IOThrottleList *qmp_query_fsdev_io_throttl

Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-05-17 Thread Eric Blake
On 05/17/2017 09:53 AM, Pradeep Jagadeesh wrote: >>> +#ifdef _WIN64 >>> + >>> +void qmp_fsdev_set_io_throttle(IOThrottle *arg, Error **errp) >>> +{ >>> + return; >>> +} >>> + >>> +IOThrottleList *qmp_query_fsdev_io_throttle(Error **errp) >>> +{ >>> +abort(); >>> +} >>> + >>> +#endif >> >> I t

Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-05-17 Thread Pradeep Jagadeesh
On 5/10/2017 10:00 PM, Eric Blake wrote: On 05/10/2017 03:41 AM, Pradeep Jagadeesh wrote: This patch enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Sign

Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-05-10 Thread Eric Blake
On 05/10/2017 03:41 AM, Pradeep Jagadeesh wrote: > This patch enables qmp interfaces for the fsdev > devices. This provides two interfaces one > for querying info of all the fsdev devices. The second one > to set the IO limits for the required fsdev device. > > Signed-off-by: Pradeep Jagadeesh >

[Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-05-10 Thread Pradeep Jagadeesh
This patch enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh --- Makefile| 3 ++ fsdev/qemu-fsdev-dum