Re: [Qemu-devel] [PATCH v4 4/4] timer: make qemu_clock_enable sync between disable and timer's cb

2013-09-23 Thread liu ping fan
On Mon, Sep 23, 2013 at 2:26 PM, Jan Kiszka wrote: > On 2013-09-22 10:11, Liu Ping Fan wrote: >> After disabling the QemuClock, we should make sure that no QemuTimers >> are still in flight. To implement that with light overhead, we resort >> to QemuEvent. The caller of disabling will wait on Qemu

Re: [Qemu-devel] [PATCH v4 4/4] timer: make qemu_clock_enable sync between disable and timer's cb

2013-09-22 Thread Jan Kiszka
On 2013-09-22 10:11, Liu Ping Fan wrote: > After disabling the QemuClock, we should make sure that no QemuTimers > are still in flight. To implement that with light overhead, we resort > to QemuEvent. The caller of disabling will wait on QemuEvent of each > timerlist. > > Note, qemu_clock_enable(f

[Qemu-devel] [PATCH v4 4/4] timer: make qemu_clock_enable sync between disable and timer's cb

2013-09-22 Thread Liu Ping Fan
After disabling the QemuClock, we should make sure that no QemuTimers are still in flight. To implement that with light overhead, we resort to QemuEvent. The caller of disabling will wait on QemuEvent of each timerlist. Note, qemu_clock_enable(foo,false) can _not_ be called from timer's cb. And th