Re: [Qemu-devel] [PATCH v4 4/5] prepare to create HPET, RTC and i8254 through composition

2012-07-20 Thread Markus Armbruster
Anthony Liguori writes: > Markus Armbruster writes: > >> Wanpeng Li writes: >> >>> [CCing ML] >>> >>> From: Anthony Liguori >>> >>> The HPET usually sits on the LPC bus (which replaces ISA in modern systems). >>> It's sometimes a dedicated chip but can certain co-exist in a Super IO chip. >

Re: [Qemu-devel] [PATCH v4 4/5] prepare to create HPET, RTC and i8254 through composition

2012-07-19 Thread Wanpeng Li
On Thu, Jul 19, 2012 at 03:23:32PM -0500, Anthony Liguori wrote: >Wanpeng Li writes: > >> [CCing ML] >> >> From: Anthony Liguori > >Each of these devices should be a separate patch. > >Please don't just send patches from branches of mine. Spend some time >to understand the code and break thin

Re: [Qemu-devel] [PATCH v4 4/5] prepare to create HPET, RTC and i8254 through composition

2012-07-19 Thread Anthony Liguori
Wanpeng Li writes: > [CCing ML] > > From: Anthony Liguori Each of these devices should be a separate patch. Please don't just send patches from branches of mine. Spend some time to understand the code and break things up appropriately. Regards, Anthony Liguori > The HPET usually sits on

Re: [Qemu-devel] [PATCH v4 4/5] prepare to create HPET, RTC and i8254 through composition

2012-07-19 Thread Anthony Liguori
Markus Armbruster writes: > Wanpeng Li writes: > >> [CCing ML] >> >> From: Anthony Liguori >> >> The HPET usually sits on the LPC bus (which replaces ISA in modern systems). >> It's sometimes a dedicated chip but can certain co-exist in a Super IO chip. >> I think in terms of where it would

Re: [Qemu-devel] [PATCH v4 4/5] prepare to create HPET, RTC and i8254 through composition

2012-07-18 Thread Markus Armbruster
Wanpeng Li writes: > [CCing ML] > > From: Anthony Liguori > > The HPET usually sits on the LPC bus (which replaces ISA in modern systems). > It's sometimes a dedicated chip but can certain co-exist in a Super IO chip. > I think in terms of where it would live in this hypothetical device model

[Qemu-devel] [PATCH v4 4/5] prepare to create HPET, RTC and i8254 through composition

2012-07-18 Thread Wanpeng Li
[CCing ML] From: Anthony Liguori The HPET usually sits on the LPC bus (which replaces ISA in modern systems). It's sometimes a dedicated chip but can certain co-exist in a Super IO chip. I think in terms of where it would live in this hypothetical device model, putting it in the PIIX is ration