Re: [Qemu-devel] [PATCH v4 4/9] MSI-X state save/load invocations moved to PCI Device save/load callbacks to avoid code duplication in MSI-X-enabled devices that support live migration

2012-03-16 Thread Dmitry Fleytman
Michael, Great. I believe higher level API if what really needed here. I'll revert this patch and move msix_load/store invocations into the device code. Thanks. On Fri, Mar 16, 2012 at 1:00 AM, Michael S. Tsirkin wrote: > On Thu, Mar 15, 2012 at 11:09:03PM +0200, Dmitry Fleytman wrote: >> Signe

Re: [Qemu-devel] [PATCH v4 4/9] MSI-X state save/load invocations moved to PCI Device save/load callbacks to avoid code duplication in MSI-X-enabled devices that support live migration

2012-03-15 Thread Michael S. Tsirkin
On Thu, Mar 15, 2012 at 11:09:03PM +0200, Dmitry Fleytman wrote: > Signed-off-by: Dmitry Fleytman > Signed-off-by: Yan Vugenfirer I'm working on a higher level API that will handle all capabilities. For now, pls just put these calls in your device. > --- > hw/pci.c|5 + > hw/v

[Qemu-devel] [PATCH v4 4/9] MSI-X state save/load invocations moved to PCI Device save/load callbacks to avoid code duplication in MSI-X-enabled devices that support live migration

2012-03-15 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/pci.c|5 + hw/virtio-pci.c |2 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index bf046bf..9146d3f 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -31,6 +31,7 @@ #include "lo