Re: [Qemu-devel] [PATCH v4 5/6] vhost: simplify vhost_needs_vring_endian()

2016-02-05 Thread Laurent Vivier
On 05/02/2016 11:46, Greg Kurz wrote: > After the call to virtio_vdev_has_feature(), we only care for legacy > devices, so we don't need the extra check in virtio_is_big_endian(). > > Also the device_endian field is always set (VIRTIO_DEVICE_ENDIAN_UNKNOWN > may only happen on a virtio_load() pa

Re: [Qemu-devel] [PATCH v4 5/6] vhost: simplify vhost_needs_vring_endian()

2016-02-05 Thread Cornelia Huck
On Fri, 05 Feb 2016 11:46:04 +0100 Greg Kurz wrote: > After the call to virtio_vdev_has_feature(), we only care for legacy > devices, so we don't need the extra check in virtio_is_big_endian(). > > Also the device_endian field is always set (VIRTIO_DEVICE_ENDIAN_UNKNOWN > may only happen on a vi

[Qemu-devel] [PATCH v4 5/6] vhost: simplify vhost_needs_vring_endian()

2016-02-05 Thread Greg Kurz
After the call to virtio_vdev_has_feature(), we only care for legacy devices, so we don't need the extra check in virtio_is_big_endian(). Also the device_endian field is always set (VIRTIO_DEVICE_ENDIAN_UNKNOWN may only happen on a virtio_load() path that cannot lead here), so we don't need the as