Re: [Qemu-devel] [PATCH v4 6/7] qdev: Protect device-list-properties against broken devices

2015-10-01 Thread Markus Armbruster
Andreas Färber writes: > Am 28.09.2015 um 22:08 schrieb Markus Armbruster: >> Several devices don't survive object_unref(object_new(T)): they crash >> or hang during cleanup, or they leave dangling pointers behind. >> >> This breaks at least device-list-properties, because >> qmp_device_list_pro

Re: [Qemu-devel] [PATCH v4 6/7] qdev: Protect device-list-properties against broken devices

2015-09-30 Thread Andreas Färber
Am 28.09.2015 um 22:08 schrieb Markus Armbruster: > Several devices don't survive object_unref(object_new(T)): they crash > or hang during cleanup, or they leave dangling pointers behind. > > This breaks at least device-list-properties, because > qmp_device_list_properties() needs to create a devi

Re: [Qemu-devel] [PATCH v4 6/7] qdev: Protect device-list-properties against broken devices

2015-09-29 Thread Thomas Huth
On 28/09/15 22:08, Markus Armbruster wrote: > Several devices don't survive object_unref(object_new(T)): they crash > or hang during cleanup, or they leave dangling pointers behind. > > This breaks at least device-list-properties, because > qmp_device_list_properties() needs to create a device to

Re: [Qemu-devel] [PATCH v4 6/7] qdev: Protect device-list-properties against broken devices

2015-09-28 Thread Eduardo Habkost
On Mon, Sep 28, 2015 at 10:08:26PM +0200, Markus Armbruster wrote: > Several devices don't survive object_unref(object_new(T)): they crash > or hang during cleanup, or they leave dangling pointers behind. > > This breaks at least device-list-properties, because > qmp_device_list_properties() needs

[Qemu-devel] [PATCH v4 6/7] qdev: Protect device-list-properties against broken devices

2015-09-28 Thread Markus Armbruster
Several devices don't survive object_unref(object_new(T)): they crash or hang during cleanup, or they leave dangling pointers behind. This breaks at least device-list-properties, because qmp_device_list_properties() needs to create a device to find its properties. Broken in commit f4eb32b "qmp: s