Re: [Qemu-devel] [PATCH v4 RFC 0/3] util/uri.c: Coding style format

2018-02-27 Thread Stefan Hajnoczi
On Sun, Feb 25, 2018 at 12:35:55PM +0800, Su Hang wrote: > Su Hang (3): > util/uri.c: Coding style check, Only whitespace involved. > util/uri.c: remove brackets () that wrap `return` statement's content. > util/uri.c: wrap single statement blocks with braces {} > > util/uri.c | 1753 >

Re: [Qemu-devel] [PATCH v4 RFC 0/3] util/uri.c: Coding style format

2018-02-25 Thread Fam Zheng
On Sun, 02/25 21:56, Thomas Huth wrote: > On 25.02.2018 05:57, no-re...@patchew.org wrote: > > LINKppc-softmmu/qemu-system-ppc > > collect2: error: ld returned 1 exit status > > make[1]: *** [Makefile:193: qemu-system-ppc] Error 1 > > make: *** [Makefile:404: subdir-ppc-softmmu] Error 2 > >

Re: [Qemu-devel] [PATCH v4 RFC 0/3] util/uri.c: Coding style format

2018-02-25 Thread Thomas Huth
On 25.02.2018 05:57, no-re...@patchew.org wrote: > Hi, > > This series failed build test on s390x host. Please find the details below. [...] > GEN trace/generated-helpers.c > CC mipsel-softmmu/trace/control-target.o > CC ppc-softmmu/memory_mapping.o > CC

Re: [Qemu-devel] [PATCH v4 RFC 0/3] util/uri.c: Coding style format

2018-02-24 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1519532963-12976-1-git-send-email-suhan...@mails.ucas.ac.cn Subject: [Qemu-devel] [PATCH v4 RFC 0/3] util/uri.c: Coding style format === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH v4 RFC 0/3] util/uri.c: Coding style format

2018-02-24 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1519533358-13759-1-git-send-email-suhan...@mails.ucas.ac.cn Subject: [Qemu-devel] [PATCH v4 RFC 0/3] util/uri.c: Coding style format === TEST SCRIPT BEGIN === #!/bin/bash

[Qemu-devel] [PATCH v4 RFC 0/3] util/uri.c: Coding style format

2018-02-24 Thread Su Hang
Su Hang (3): util/uri.c: Coding style check, Only whitespace involved. util/uri.c: remove brackets () that wrap `return` statement's content. util/uri.c: wrap single statement blocks with braces {} util/uri.c | 1753 1 file

[Qemu-devel] [PATCH v4 RFC 0/3] util/uri.c: Coding style format

2018-02-24 Thread Su Hang
*** BLURB HERE *** Su Hang (3): util/uri.c: Coding style check, Only whitespace involved. util/uri.c: remove brackets () that wrap `return` statement's content. util/uri.c: wrap single statement blocks with braces {} util/uri.c | 1753