Re: [Qemu-devel] [PATCH v5] PING: Fix ATA SMART and CHECK POWER MODE

2011-03-09 Thread Kevin Wolf
Am 09.03.2011 05:26, schrieb Ryan Harper: > * Brian Wheeler [2011-03-01 07:35]: >> This patch fixes two things: >> >> 1) CHECK POWER MODE >> >> The error return value wasn't always zero, so it would show up as >> offline. Error is now explicitly set to zero. >> >> 2) SMART >> >> The smart value

Re: [Qemu-devel] [PATCH v5] PING: Fix ATA SMART and CHECK POWER MODE

2011-03-08 Thread Ryan Harper
* Brian Wheeler [2011-03-01 07:35]: > This patch fixes two things: > > 1) CHECK POWER MODE > > The error return value wasn't always zero, so it would show up as > offline. Error is now explicitly set to zero. > > 2) SMART > > The smart values that were returned were invalid and tools like s

Re: [Qemu-devel] [PATCH v5] PING: Fix ATA SMART and CHECK POWER MODE

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 8:28 AM, Kevin Wolf wrote: > Am 06.03.2011 20:26, schrieb Aurelien Jarno: >> You should Cc: the IDE maintainer (Kevin Wolf) so that this patch can >> get acked. Done with this mail. > > Thanks. In fact, I saw the patch, but it still needs a review. Can > whoever commented on

Re: [Qemu-devel] [PATCH v5] PING: Fix ATA SMART and CHECK POWER MODE

2011-03-07 Thread Kevin Wolf
Am 06.03.2011 20:26, schrieb Aurelien Jarno: > You should Cc: the IDE maintainer (Kevin Wolf) so that this patch can > get acked. Done with this mail. Thanks. In fact, I saw the patch, but it still needs a review. Can whoever commented on the previous versions give it the review and post an Acked

Re: [Qemu-devel] [PATCH v5] PING: Fix ATA SMART and CHECK POWER MODE

2011-03-06 Thread Aurelien Jarno
You should Cc: the IDE maintainer (Kevin Wolf) so that this patch can get acked. Done with this mail. On Tue, Mar 01, 2011 at 08:30:23AM -0500, Brian Wheeler wrote: > This patch fixes two things: > > 1) CHECK POWER MODE > > The error return value wasn't always zero, so it would show up as >

[Qemu-devel] [PATCH v5] PING: Fix ATA SMART and CHECK POWER MODE

2011-03-01 Thread Brian Wheeler
This patch fixes two things: 1) CHECK POWER MODE The error return value wasn't always zero, so it would show up as offline. Error is now explicitly set to zero. 2) SMART The smart values that were returned were invalid and tools like skdump would not recognize that the smart data was act