Re: [Qemu-devel] [PATCH v5] qemu-nbd: Implement socket activation.

2017-02-06 Thread Paolo Bonzini
On 06/02/2017 20:04, Eric Blake wrote: > This is not the right way to do things (it risks clearing any other FD_ > flags currently set on the fd, even though there aren't any such FD_ > flags in common use). There aren't any such flags at all really, and because no one uses F_GETFD, it's unlikel

Re: [Qemu-devel] [PATCH v5] qemu-nbd: Implement socket activation.

2017-02-06 Thread Eric Blake
On 02/04/2017 04:03 AM, Richard W.M. Jones wrote: > Socket activation (sometimes known as systemd socket activation) > allows an Internet superserver to pass a pre-opened listening socket > to the process, instead of having qemu-nbd open a socket itself. This > is done via the LISTEN_FDS and LISTE

Re: [Qemu-devel] [PATCH v5] qemu-nbd: Implement socket activation.

2017-02-06 Thread Paolo Bonzini
On 06/02/2017 17:29, Richard W.M. Jones wrote: > On Mon, Feb 06, 2017 at 05:10:13PM +0100, Paolo Bonzini wrote: >> Queued, thanks. > > Could you change this comment s/!_WIN32/_WIN32/, or do you > want me to submit another patch? > >>> +#else /* !_WIN32 */ >>> +static unsigned int check_socket_a

Re: [Qemu-devel] [PATCH v5] qemu-nbd: Implement socket activation.

2017-02-06 Thread Richard W.M. Jones
On Mon, Feb 06, 2017 at 05:10:13PM +0100, Paolo Bonzini wrote: > Queued, thanks. Could you change this comment s/!_WIN32/_WIN32/, or do you want me to submit another patch? > > +#else /* !_WIN32 */ > > +static unsigned int check_socket_activation(void) > > +{ > > +return 0; > > +} > > +#endif

Re: [Qemu-devel] [PATCH v5] qemu-nbd: Implement socket activation.

2017-02-06 Thread Paolo Bonzini
On 04/02/2017 11:03, Richard W.M. Jones wrote: > Socket activation (sometimes known as systemd socket activation) > allows an Internet superserver to pass a pre-opened listening socket > to the process, instead of having qemu-nbd open a socket itself. This > is done via the LISTEN_FDS and LISTEN

[Qemu-devel] [PATCH v5] qemu-nbd: Implement socket activation.

2017-02-04 Thread Richard W.M. Jones
v3 -> v5: - Use stringify() macro (thanks Markus). - Remove --fork restriction again. - Retest with virt-p2v. Rich.

[Qemu-devel] [PATCH v5] qemu-nbd: Implement socket activation.

2017-02-04 Thread Richard W.M. Jones
Socket activation (sometimes known as systemd socket activation) allows an Internet superserver to pass a pre-opened listening socket to the process, instead of having qemu-nbd open a socket itself. This is done via the LISTEN_FDS and LISTEN_PID environment variables, and a standard file descripto