[Qemu-devel] [PATCH v5 02/11] block/dirty-bitmap: remove assertion from restore

2018-12-19 Thread John Snow
When making a backup of a dirty bitmap (for transactions), we want to restore that backup whether or not the bitmap is enabled or not. It is perfectly valid to write into bitmaps that are disabled. It is only illegitimate for the guest to have done so. Remove this assertion. Signed-off-by: John

Re: [Qemu-devel] [PATCH v5 02/11] block/dirty-bitmap: remove assertion from restore

2018-12-19 Thread Eric Blake
On 12/19/18 8:29 PM, John Snow wrote: When making a backup of a dirty bitmap (for transactions), we want to restore that backup whether or not the bitmap is enabled or not. drop one of the two 'or not' It is perfectly valid to write into bitmaps that are disabled. It is only illegitimate for

Re: [Qemu-devel] [PATCH v5 02/11] block/dirty-bitmap: remove assertion from restore

2018-12-20 Thread Vladimir Sementsov-Ogievskiy
20.12.2018 5:29, John Snow wrote: > When making a backup of a dirty bitmap (for transactions), we want to > restore that backup whether or not the bitmap is enabled or not. > > It is perfectly valid to write into bitmaps that are disabled. It is > only illegitimate for the guest to have done so. >