Re: [Qemu-devel] [PATCH v5 02/15] memory: Access MemoryRegion with MemOp

2019-07-26 Thread Richard Henderson
On 7/26/19 6:36 AM, Richard Henderson wrote: > On 7/25/19 11:43 PM, tony.ngu...@bt.com wrote: >> } MemOp; >> >> +/* No-op while memory_region_dispatch_[read|write] is converted to MemOp */ >> +#define MEMOP_SIZE(op) (op)/* MemOp to size. */ >> +#define SIZE_MEMOP(ul) (ul)/* Size to MemO

Re: [Qemu-devel] [PATCH v5 02/15] memory: Access MemoryRegion with MemOp

2019-07-26 Thread Richard Henderson
On 7/25/19 11:43 PM, tony.ngu...@bt.com wrote: > } MemOp; > > +/* No-op while memory_region_dispatch_[read|write] is converted to MemOp */ > +#define MEMOP_SIZE(op) (op)/* MemOp to size. */ > +#define SIZE_MEMOP(ul) (ul)/* Size to MemOp. */ > + This doesn't thrill me, because for 9 p

[Qemu-devel] [PATCH v5 02/15] memory: Access MemoryRegion with MemOp

2019-07-25 Thread tony.nguyen
Change memory_region_dispatch_{read|write} parameter "unsigned size" to "MemOp op". The endianness encoded in MemOp will enable the collapse of two byte swaps, adjust_endianness and handle_bswap, along the I/O path. Interfaces will be converted in two steps: first syntactically then semantically.