Re: [Qemu-devel] [PATCH v5 04/11] blockdev: drop redundant proto_drv check

2013-06-19 Thread Kevin Wolf
Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben: > It is not necessary to check that we can find a protocol block driver > since we create or open the image file. This produces the error that we > need anyway. > > Besides, the QERR_INVALID_BLOCK_FORMAT is inappropriate since the > protocol

Re: [Qemu-devel] [PATCH v5 04/11] blockdev: drop redundant proto_drv check

2013-06-05 Thread Wenchao Xia
于 2013-5-30 20:34, Stefan Hajnoczi 写道: > It is not necessary to check that we can find a protocol block driver > since we create or open the image file. This produces the error that we > need anyway. > > Besides, the QERR_INVALID_BLOCK_FORMAT is inappropriate since the > protocol is incorrect rat

Re: [Qemu-devel] [PATCH v5 04/11] blockdev: drop redundant proto_drv check

2013-06-03 Thread Eric Blake
On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote: > It is not necessary to check that we can find a protocol block driver > since we create or open the image file. This produces the error that we > need anyway. > > Besides, the QERR_INVALID_BLOCK_FORMAT is inappropriate since the > protocol is incor

[Qemu-devel] [PATCH v5 04/11] blockdev: drop redundant proto_drv check

2013-05-30 Thread Stefan Hajnoczi
It is not necessary to check that we can find a protocol block driver since we create or open the image file. This produces the error that we need anyway. Besides, the QERR_INVALID_BLOCK_FORMAT is inappropriate since the protocol is incorrect rather than the format. Also drop an empty line betwe