Re: [Qemu-devel] [PATCH v5 06/14] qapi: remove '-q' arg to diff when comparing QAPI output

2018-02-12 Thread Daniel P . Berrangé
On Fri, Feb 09, 2018 at 05:39:58PM -0600, Eric Blake wrote: > On 01/16/2018 07:42 AM, Daniel P. Berrange wrote: > > When the qapi schema tests fail they merely print that the expected > > output didn't match the actual output. This is largely useless when > > trying diagnose what went wrong.

Re: [Qemu-devel] [PATCH v5 06/14] qapi: remove '-q' arg to diff when comparing QAPI output

2018-02-09 Thread Markus Armbruster
Eric Blake writes: > On 01/16/2018 07:42 AM, Daniel P. Berrange wrote: >> When the qapi schema tests fail they merely print that the expected >> output didn't match the actual output. This is largely useless when >> trying diagnose what went wrong. Removing the '-q' arg to

Re: [Qemu-devel] [PATCH v5 06/14] qapi: remove '-q' arg to diff when comparing QAPI output

2018-02-09 Thread Eric Blake
On 01/16/2018 07:42 AM, Daniel P. Berrange wrote: When the qapi schema tests fail they merely print that the expected output didn't match the actual output. This is largely useless when trying diagnose what went wrong. Removing the '-q' arg to diff means that it is still silent on successful

[Qemu-devel] [PATCH v5 06/14] qapi: remove '-q' arg to diff when comparing QAPI output

2018-01-16 Thread Daniel P. Berrange
When the qapi schema tests fail they merely print that the expected output didn't match the actual output. This is largely useless when trying diagnose what went wrong. Removing the '-q' arg to diff means that it is still silent on successful tests, but when it fails we'll see details of the