Kevin Wolf writes:
> Am 31.03.2015 um 22:46 hat Markus Armbruster geschrieben:
>> Kevin Wolf writes:
>>
>> > Am 26.03.2015 um 16:04 hat Eric Blake geschrieben:
>> >> On 03/26/2015 07:18 AM, Markus Armbruster wrote:
>> >> > Eric Blake writes:
>> >> >> Meanwhile, it would be
Am 31.03.2015 um 22:46 hat Markus Armbruster geschrieben:
> Kevin Wolf writes:
>
> > Am 26.03.2015 um 16:04 hat Eric Blake geschrieben:
> >> On 03/26/2015 07:18 AM, Markus Armbruster wrote:
> >> > Eric Blake writes:
> >> >> Meanwhile, it would be nice to allow
> >> >> 'discri
On 03/30/2015 04:45 PM, Eric Blake wrote:
> On 03/26/2015 09:58 AM, Markus Armbruster wrote:
>
/home/armbru/work/qemu/.git/rebase-apply/patch:325: new blank line at EOF.
>>>
>>> Huh. I thought I had git set up to reject me from making commits like
>>> that locally, but obviously not.
>>
>> Th
Kevin Wolf writes:
> Am 26.03.2015 um 16:04 hat Eric Blake geschrieben:
>> On 03/26/2015 07:18 AM, Markus Armbruster wrote:
>> > Eric Blake writes:
>> >> Meanwhile, it would be nice to allow
>> >> 'discriminator':'EnumType' without 'base' for creating a simple union
>> >> tha
On 03/31/2015 12:15 PM, Eric Blake wrote:
>>> Cool. Or more concretely,
>>>
>>> { 'union': 'Simple', 'data': { 'one': 'str', 'two': 'int' } }
>>>
>>> is identical on the wire to:
>>>
>>> { 'enum': 'MyEnum', 'data': ['one', 'two'] }
>>> { 'type': 'Base', 'data': { 'type': 'MyEnum' } }
>>> { 'type'
Am 31.03.2015 um 20:15 hat Eric Blake geschrieben:
> On 03/31/2015 11:13 AM, Kevin Wolf wrote:
>
> >> [3]
> >> { 'union':'SimpleAndSafe', 'discriminator':'MyEnum',
> >> 'data':{ 'one':'str', 'two':'int' }}
> >>
> >> {"execute":"foo", "arguments":{'type':'one', 'data':'hello'}}
> >
> > This woul
On 03/31/2015 11:13 AM, Kevin Wolf wrote:
>> [3]
>> { 'union':'SimpleAndSafe', 'discriminator':'MyEnum',
>> 'data':{ 'one':'str', 'two':'int' }}
>>
>> {"execute":"foo", "arguments":{'type':'one', 'data':'hello'}}
>
> This would overload 'discriminator' with two different meanings:
>
> * In cas
Am 26.03.2015 um 16:04 hat Eric Blake geschrieben:
> On 03/26/2015 07:18 AM, Markus Armbruster wrote:
> > Eric Blake writes:
> >> Meanwhile, it would be nice to allow
> >> 'discriminator':'EnumType' without 'base' for creating a simple union
> >> that is type-safe rather than o
On 03/26/2015 09:58 AM, Markus Armbruster wrote:
>>> /home/armbru/work/qemu/.git/rebase-apply/patch:325: new blank line at EOF.
>>
>> Huh. I thought I had git set up to reject me from making commits like
>> that locally, but obviously not.
>
> There's another one in PATCH 13:
>
> /home/armbru/wo
On 03/27/2015 06:30 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> On 03/26/2015 07:18 AM, Markus Armbruster wrote:
>>> Eric Blake writes:
>>>
Demonstrate that the qapi generator doesn't deal well with unions
that aren't up to par. Later patches will update the expected
re
Eric Blake writes:
> On 03/26/2015 07:18 AM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> Demonstrate that the qapi generator doesn't deal well with unions
>>> that aren't up to par. Later patches will update the expected
>>> reseults as the generator is made stricter.
>>>
>>> Of parti
Eric Blake writes:
> On 03/26/2015 07:23 AM, Markus Armbruster wrote:
>> One more:
>>
>> [...]
>>> diff --git a/tests/qapi-schema/alternate-conflict-string.json
>>> b/tests/qapi-schema/alternate-conflict-string.json
>>> new file mode 100644
>>> index 000..5fd1a47
>>> --- /dev/null
>>> +++ b/
On 03/26/2015 07:18 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> Demonstrate that the qapi generator doesn't deal well with unions
>> that aren't up to par. Later patches will update the expected
>> reseults as the generator is made stricter.
>>
>> Of particular note, we currently allow
On 03/26/2015 07:23 AM, Markus Armbruster wrote:
> One more:
>
> [...]
>> diff --git a/tests/qapi-schema/alternate-conflict-string.json
>> b/tests/qapi-schema/alternate-conflict-string.json
>> new file mode 100644
>> index 000..5fd1a47
>> --- /dev/null
>> +++ b/tests/qapi-schema/alternate-con
One more:
[...]
> diff --git a/tests/qapi-schema/alternate-conflict-string.json
> b/tests/qapi-schema/alternate-conflict-string.json
> new file mode 100644
> index 000..5fd1a47
> --- /dev/null
> +++ b/tests/qapi-schema/alternate-conflict-string.json
> @@ -0,0 +1,8 @@
> +# FIXME: we should rej
Eric Blake writes:
> Demonstrate that the qapi generator doesn't deal well with unions
> that aren't up to par. Later patches will update the expected
> reseults as the generator is made stricter.
>
> Of particular note, we currently allow 'base' without 'discriminator'
> as a way to create a sim
Demonstrate that the qapi generator doesn't deal well with unions
that aren't up to par. Later patches will update the expected
reseults as the generator is made stricter.
Of particular note, we currently allow 'base' without 'discriminator'
as a way to create a simple union with a base class. Ho
17 matches
Mail list logo
