Re: [Qemu-devel] [PATCH v5 07/73] cpu: make per-CPU locks an alias of the BQL in TCG rr mode

2018-12-14 Thread Emilio G. Cota
On Thu, Dec 13, 2018 at 00:03:47 -0500, Emilio G. Cota wrote: (snip) > diff --git a/qom/cpu.c b/qom/cpu.c > index aa15ea4af5..2ea5b1da08 100644 > --- a/qom/cpu.c > +++ b/qom/cpu.c > @@ -371,7 +371,6 @@ static void cpu_common_initfn(Object *obj) > cpu->nr_cores = 1; > cpu->nr_threads = 1;

[Qemu-devel] [PATCH v5 07/73] cpu: make per-CPU locks an alias of the BQL in TCG rr mode

2018-12-12 Thread Emilio G. Cota
Before we can switch from the BQL to per-CPU locks in the CPU loop, we have to accommodate the fact that TCG rr mode (i.e. !MTTCG) cannot work with separate per-vCPU locks. That would lead to deadlock since we need a single lock/condvar pair on which to wait for events that affect any vCPU, e.g. in