Re: [Qemu-devel] [PATCH v5 08/28] qapi: Better error messages for bad unions

2015-03-26 Thread Markus Armbruster
Subject suggests you're just polishing error messages here. In fact, you're fixing the generator to detect errors. Suggest something like qapi: Tighten checking of unions Eric Blake writes: > Previous commits demonstrated that the generator had several > flaws with less-than-perfect union

Re: [Qemu-devel] [PATCH v5 08/28] qapi: Better error messages for bad unions

2015-03-24 Thread Eric Blake
On 03/24/2015 02:03 PM, Eric Blake wrote: > Previous commits demonstrated that the generator had several > flaws with less-than-perfect unions: > - make the use of a base without discriminator a hard error, > since the previous patch removed all remaining uses of it > - a simple union that listed t

[Qemu-devel] [PATCH v5 08/28] qapi: Better error messages for bad unions

2015-03-24 Thread Eric Blake
Previous commits demonstrated that the generator had several flaws with less-than-perfect unions: - make the use of a base without discriminator a hard error, since the previous patch removed all remaining uses of it - a simple union that listed the same branch twice (or two variant names that map