Re: [Qemu-devel] [PATCH v5 09/19] tcg-arm: Implement deposit for armv7

2013-04-22 Thread Aurelien Jarno
On Sun, Apr 21, 2013 at 05:58:33PM +0100, Richard Henderson wrote: > On 2013-04-21 11:35, Aurelien Jarno wrote: > >Wouldn't it be better to only declare the zero constraint (using bfc in > >that case), and let the middle-end to load the constant in other cases? > > Possibly. I wondered if the wor

Re: [Qemu-devel] [PATCH v5 09/19] tcg-arm: Implement deposit for armv7

2013-04-21 Thread Richard Henderson
On 2013-04-21 11:35, Aurelien Jarno wrote: Wouldn't it be better to only declare the zero constraint (using bfc in that case), and let the middle-end to load the constant in other cases? Possibly. I wondered if the work of the extra constraint was worth the effort. r~

Re: [Qemu-devel] [PATCH v5 09/19] tcg-arm: Implement deposit for armv7

2013-04-21 Thread Aurelien Jarno
On Sun, Mar 31, 2013 at 03:34:55PM -0700, Richard Henderson wrote: > We have BFI and BFC available for implementing it. > > Signed-off-by: Richard Henderson > --- > tcg/arm/tcg-target.c | 36 > tcg/arm/tcg-target.h | 5 - > 2 files changed, 40 insertions

[Qemu-devel] [PATCH v5 09/19] tcg-arm: Implement deposit for armv7

2013-03-31 Thread Richard Henderson
We have BFI and BFC available for implementing it. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 36 tcg/arm/tcg-target.h | 5 - 2 files changed, 40 insertions(+), 1 deletion(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c inde