Re: [Qemu-devel] [PATCH v5 1/4] target/arm: implement SHA-512 instructions

2018-02-06 Thread Richard Henderson
On 02/06/2018 11:15 AM, Peter Maydell wrote: > My test setup doesn't capture register values from > before the insn executes... I have patches for RISU to dump each record written to the trace file, which does allow one to go back and examine previous register values. r~

Re: [Qemu-devel] [PATCH v5 1/4] target/arm: implement SHA-512 instructions

2018-02-06 Thread Peter Maydell
On 6 February 2018 at 19:59, Ard Biesheuvel wrote: > Thanks a lot for debugging that. As I said, I don't have test vectors, > or I would have tested it myself, and most likely would have found > this as well. No problem. I spent a surprisingly long time looking at the inside of the loop trying to

Re: [Qemu-devel] [PATCH v5 1/4] target/arm: implement SHA-512 instructions

2018-02-06 Thread Ard Biesheuvel
On 6 February 2018 at 20:41, Peter Maydell wrote: > On 6 February 2018 at 19:15, Peter Maydell wrote: >> On 6 February 2018 at 19:06, Peter Maydell wrote: >>> SM4EKEY, SM4E >> >> Sample SM4EKEY failure: >> insn 0xce78cbdd (SM4EKEY V29.4S, V30.4S, V24.4S) >> V24 : 6ee7a2520059bd15bac75e4436b3

Re: [Qemu-devel] [PATCH v5 1/4] target/arm: implement SHA-512 instructions

2018-02-06 Thread Peter Maydell
On 6 February 2018 at 19:15, Peter Maydell wrote: > On 6 February 2018 at 19:06, Peter Maydell wrote: >> SM4EKEY, SM4E > > Sample SM4EKEY failure: > insn 0xce78cbdd (SM4EKEY V29.4S, V30.4S, V24.4S) > V24 : 6ee7a2520059bd15bac75e4436b3a1bd > V30 : a67d04e738f68da895ffd0c3e154e3e7 > > V29

Re: [Qemu-devel] [PATCH v5 1/4] target/arm: implement SHA-512 instructions

2018-02-06 Thread Peter Maydell
On 6 February 2018 at 19:06, Peter Maydell wrote: > SM4EKEY, SM4E Sample SM4EKEY failure: insn 0xce78cbdd (SM4EKEY V29.4S, V30.4S, V24.4S) V24 : 6ee7a2520059bd15bac75e4436b3a1bd V30 : a67d04e738f68da895ffd0c3e154e3e7 V29 actual: a67d04e7b98aaef47bf01b8158da5407 V29 expected: 8d4922

Re: [Qemu-devel] [PATCH v5 1/4] target/arm: implement SHA-512 instructions

2018-02-06 Thread Peter Maydell
On 6 February 2018 at 18:57, Ard Biesheuvel wrote: > On 6 February 2018 at 18:56, Ard Biesheuvel wrote: >> On 6 February 2018 at 18:45, Peter Maydell wrote: >>> On 22 January 2018 at 17:26, Ard Biesheuvel >>> wrote: This implements emulation of the new SHA-512 instructions that have

Re: [Qemu-devel] [PATCH v5 1/4] target/arm: implement SHA-512 instructions

2018-02-06 Thread Ard Biesheuvel
On 6 February 2018 at 18:45, Peter Maydell wrote: > On 22 January 2018 at 17:26, Ard Biesheuvel wrote: >> This implements emulation of the new SHA-512 instructions that have >> been added as an optional extensions to the ARMv8 Crypto Extensions >> in ARM v8.2. >> >> Signed-off-by: Ard Biesheuvel

Re: [Qemu-devel] [PATCH v5 1/4] target/arm: implement SHA-512 instructions

2018-02-06 Thread Ard Biesheuvel
On 6 February 2018 at 18:56, Ard Biesheuvel wrote: > On 6 February 2018 at 18:45, Peter Maydell wrote: >> On 22 January 2018 at 17:26, Ard Biesheuvel >> wrote: >>> This implements emulation of the new SHA-512 instructions that have >>> been added as an optional extensions to the ARMv8 Crypto Ex

Re: [Qemu-devel] [PATCH v5 1/4] target/arm: implement SHA-512 instructions

2018-02-06 Thread Peter Maydell
On 22 January 2018 at 17:26, Ard Biesheuvel wrote: > This implements emulation of the new SHA-512 instructions that have > been added as an optional extensions to the ARMv8 Crypto Extensions > in ARM v8.2. > > Signed-off-by: Ard Biesheuvel > +void HELPER(crypto_sha512h)(void *vd, void *vn, void

[Qemu-devel] [PATCH v5 1/4] target/arm: implement SHA-512 instructions

2018-01-22 Thread Ard Biesheuvel
This implements emulation of the new SHA-512 instructions that have been added as an optional extensions to the ARMv8 Crypto Extensions in ARM v8.2. Signed-off-by: Ard Biesheuvel --- target/arm/cpu.h | 1 + target/arm/crypto_helper.c | 75 - target/arm/helper.h|