Re: [Qemu-devel] [PATCH v5 1/5] hpet: inverse polarity when pin above ISA_NUM_IRQS

2013-09-30 Thread liu ping fan
On Sun, Sep 29, 2013 at 12:20 PM, Michael S. Tsirkin wrote: > On Sun, Sep 29, 2013 at 11:25:24AM +0800, liu ping fan wrote: >> On Sun, Sep 29, 2013 at 3:52 AM, Michael S. Tsirkin wrote: >> > On Thu, Sep 12, 2013 at 11:25:14AM +0800, Liu Ping Fan wrote: >> >> According to hpet spec, hpet irq is hi

Re: [Qemu-devel] [PATCH v5 1/5] hpet: inverse polarity when pin above ISA_NUM_IRQS

2013-09-28 Thread Michael S. Tsirkin
On Sun, Sep 29, 2013 at 11:25:24AM +0800, liu ping fan wrote: > On Sun, Sep 29, 2013 at 3:52 AM, Michael S. Tsirkin wrote: > > On Thu, Sep 12, 2013 at 11:25:14AM +0800, Liu Ping Fan wrote: > >> According to hpet spec, hpet irq is high active. But according to > >> ICH spec, there is inversion befo

Re: [Qemu-devel] [PATCH v5 1/5] hpet: inverse polarity when pin above ISA_NUM_IRQS

2013-09-28 Thread liu ping fan
On Sun, Sep 29, 2013 at 3:52 AM, Michael S. Tsirkin wrote: > On Thu, Sep 12, 2013 at 11:25:14AM +0800, Liu Ping Fan wrote: >> According to hpet spec, hpet irq is high active. But according to >> ICH spec, there is inversion before the input of ioapic. So the OS >> will expect low active on this IR

Re: [Qemu-devel] [PATCH v5 1/5] hpet: inverse polarity when pin above ISA_NUM_IRQS

2013-09-28 Thread Michael S. Tsirkin
On Thu, Sep 12, 2013 at 11:25:14AM +0800, Liu Ping Fan wrote: > According to hpet spec, hpet irq is high active. But according to > ICH spec, there is inversion before the input of ioapic. So the OS > will expect low active on this IRQ line. >(And this is observed on > bare metal). How does one

[Qemu-devel] [PATCH v5 1/5] hpet: inverse polarity when pin above ISA_NUM_IRQS

2013-09-11 Thread Liu Ping Fan
According to hpet spec, hpet irq is high active. But according to ICH spec, there is inversion before the input of ioapic. So the OS will expect low active on this IRQ line.(And this is observed on bare metal). We fold the emulation of this inversion inside the hpet logic. Signed-off-by: Liu Ping