Re: [Qemu-devel] [PATCH v5 1/9] Add cache handling functions

2012-01-04 Thread Orit Wasserman
On 01/03/2012 09:54 PM, Anthony Liguori wrote: On 01/03/2012 09:34 AM, Orit Wasserman wrote: Add page caching mechanism. The pages are stored in the cache ordered by their address. Signed-off-by: Orit Wassermanowass...@redhat.com --- arch_init.c | 183

Re: [Qemu-devel] [PATCH v5 1/9] Add cache handling functions

2012-01-04 Thread Stefan Hajnoczi
On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman owass...@redhat.com wrote: +static unsigned long cache_get_cache_pos(ram_addr_t address) +{ +    unsigned long pos; + +    assert(cache_num_buckets); +    pos = (address/TARGET_PAGE_SIZE) (cache_num_buckets - 1); Where do we guarantee that

Re: [Qemu-devel] [PATCH v5 1/9] Add cache handling functions

2012-01-04 Thread Orit Wasserman
On 01/04/2012 01:46 PM, Stefan Hajnoczi wrote: On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman owass...@redhat.com wrote: +static unsigned long cache_get_cache_pos(ram_addr_t address) +{ +unsigned long pos; + +assert(cache_num_buckets); +pos = (address/TARGET_PAGE_SIZE)

Re: [Qemu-devel] [PATCH v5 1/9] Add cache handling functions

2012-01-04 Thread Michael Roth
On 01/04/2012 03:29 AM, Orit Wasserman wrote: On 01/03/2012 09:54 PM, Anthony Liguori wrote: On 01/03/2012 09:34 AM, Orit Wasserman wrote: Add page caching mechanism. The pages are stored in the cache ordered by their address. Signed-off-by: Orit Wassermanowass...@redhat.com ---

[Qemu-devel] [PATCH v5 1/9] Add cache handling functions

2012-01-03 Thread Orit Wasserman
Add page caching mechanism. The pages are stored in the cache ordered by their address. Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 183 +++ 1 files changed, 183 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v5 1/9] Add cache handling functions

2012-01-03 Thread Anthony Liguori
On 01/03/2012 09:34 AM, Orit Wasserman wrote: Add page caching mechanism. The pages are stored in the cache ordered by their address. Signed-off-by: Orit Wassermanowass...@redhat.com --- arch_init.c | 183 +++ 1 files changed, 183

[Qemu-devel] [PATCH v5 1/9] Add cache handling functions

2012-01-03 Thread Orit Wasserman
Add page caching mechanism. The pages are stored in the cache ordered by their address. Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 183 +++ 1 files changed, 183 insertions(+), 0 deletions(-) diff --git