Re: [Qemu-devel] [PATCH v5 10/10] test-qga: Actually test 0xff sync bytes

2017-05-04 Thread Eric Blake
On 05/04/2017 02:23 AM, Markus Armbruster wrote: >>> Feel free to suggest something for me to add to the commit message. >> >> Maybe change: >> >> "which matches the documented actions that a real QGA client >>is supposed to do." >> >> to >> >> "which is compatible with the documented acti

Re: [Qemu-devel] [PATCH v5 10/10] test-qga: Actually test 0xff sync bytes

2017-05-04 Thread Markus Armbruster
Michael Roth writes: > Quoting Markus Armbruster (2017-05-03 03:57:41) >> Michael Roth writes: >> >> > Quoting Michael Roth (2017-05-02 11:46:36) >> >> Quoting Eric Blake (2017-04-27 16:58:21) >> >> > Commit 62c39b3 introduced test-qga, and at face value, appears >> >> > to be testing the 'gues

Re: [Qemu-devel] [PATCH v5 10/10] test-qga: Actually test 0xff sync bytes

2017-05-03 Thread Michael Roth
Quoting Markus Armbruster (2017-05-03 03:57:41) > Michael Roth writes: > > > Quoting Michael Roth (2017-05-02 11:46:36) > >> Quoting Eric Blake (2017-04-27 16:58:21) > >> > Commit 62c39b3 introduced test-qga, and at face value, appears > >> > to be testing the 'guest-sync' behavior that is recomm

Re: [Qemu-devel] [PATCH v5 10/10] test-qga: Actually test 0xff sync bytes

2017-05-03 Thread Markus Armbruster
Michael Roth writes: > Quoting Michael Roth (2017-05-02 11:46:36) >> Quoting Eric Blake (2017-04-27 16:58:21) >> > Commit 62c39b3 introduced test-qga, and at face value, appears >> > to be testing the 'guest-sync' behavior that is recommended for >> > guests in sending 0xff to QGA to force the pa

Re: [Qemu-devel] [PATCH v5 10/10] test-qga: Actually test 0xff sync bytes

2017-05-02 Thread Michael Roth
Quoting Michael Roth (2017-05-02 11:46:36) > Quoting Eric Blake (2017-04-27 16:58:21) > > Commit 62c39b3 introduced test-qga, and at face value, appears > > to be testing the 'guest-sync' behavior that is recommended for > > guests in sending 0xff to QGA to force the parser to reset. But > > this

Re: [Qemu-devel] [PATCH v5 10/10] test-qga: Actually test 0xff sync bytes

2017-05-02 Thread Michael Roth
Quoting Eric Blake (2017-04-27 16:58:21) > Commit 62c39b3 introduced test-qga, and at face value, appears > to be testing the 'guest-sync' behavior that is recommended for > guests in sending 0xff to QGA to force the parser to reset. But > this aspect of the test has never actually done anything:

[Qemu-devel] [PATCH v5 10/10] test-qga: Actually test 0xff sync bytes

2017-04-27 Thread Eric Blake
Commit 62c39b3 introduced test-qga, and at face value, appears to be testing the 'guest-sync' behavior that is recommended for guests in sending 0xff to QGA to force the parser to reset. But this aspect of the test has never actually done anything: the qmp_fd() call chain converts its string argum