Re: [Qemu-devel] [PATCH v5 10/11] pci core: assert ENOSPC when add capability

2016-05-16 Thread Cao jin
On 05/15/2016 09:10 PM, Marcel Apfelbaum wrote: On 05/06/2016 07:20 AM, Cao jin wrote: ENOSPC is programming error, assert it for debugging. +/* out of PCI config space should be programming error */ 'is', not 'should be' Will fix it. Thank You, Marcel. I guess I should put this

Re: [Qemu-devel] [PATCH v5 10/11] pci core: assert ENOSPC when add capability

2016-05-15 Thread Marcel Apfelbaum
On 05/06/2016 07:20 AM, Cao jin wrote: ENOSPC is programming error, assert it for debugging. cc: Michael S. Tsirkin cc: Marcel Apfelbaum cc: Markus Armbruster Signed-off-by: Cao jin --- hw/pci/pci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/pci/pci.c b/h

[Qemu-devel] [PATCH v5 10/11] pci core: assert ENOSPC when add capability

2016-05-05 Thread Cao jin
ENOSPC is programming error, assert it for debugging. cc: Michael S. Tsirkin cc: Marcel Apfelbaum cc: Markus Armbruster Signed-off-by: Cao jin --- hw/pci/pci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index f0f41dc..fc8b377 100644 -