Re: [Qemu-devel] [PATCH v5 16/28] qapi: Better error messages for duplicated expressions

2015-03-29 Thread Markus Armbruster
Eric Blake writes: > On 03/27/2015 01:52 AM, Markus Armbruster wrote: >> One more... >> >> Eric Blake writes: >> >> [...] >>> diff --git a/scripts/qapi.py b/scripts/qapi.py >>> index 90eb3bc..5d0dc91 100644 >>> --- a/scripts/qapi.py >>> +++ b/scripts/qapi.py >> [...] >>> @@ -560,12 +585,22 @@

Re: [Qemu-devel] [PATCH v5 16/28] qapi: Better error messages for duplicated expressions

2015-03-27 Thread Eric Blake
On 03/27/2015 01:52 AM, Markus Armbruster wrote: > One more... > > Eric Blake writes: > > [...] >> diff --git a/scripts/qapi.py b/scripts/qapi.py >> index 90eb3bc..5d0dc91 100644 >> --- a/scripts/qapi.py >> +++ b/scripts/qapi.py > [...] >> @@ -560,12 +585,22 @@ def type_name(name): >> r

Re: [Qemu-devel] [PATCH v5 16/28] qapi: Better error messages for duplicated expressions

2015-03-27 Thread Markus Armbruster
One more... Eric Blake writes: [...] > diff --git a/scripts/qapi.py b/scripts/qapi.py > index 90eb3bc..5d0dc91 100644 > --- a/scripts/qapi.py > +++ b/scripts/qapi.py [...] > @@ -560,12 +585,22 @@ def type_name(name): > return c_list_type(name[0]) > return name > > -enum_types = []

Re: [Qemu-devel] [PATCH v5 16/28] qapi: Better error messages for duplicated expressions

2015-03-26 Thread Markus Armbruster
Eric Blake writes: > The previous commit demonstrated that the generator overlooked > duplicate expressions: > - a complex type or command reusing a built-in type name > - redeclaration of a type name, whether by the same or different > metatype > - redeclaration of a command or event > - collisi

[Qemu-devel] [PATCH v5 16/28] qapi: Better error messages for duplicated expressions

2015-03-24 Thread Eric Blake
The previous commit demonstrated that the generator overlooked duplicate expressions: - a complex type or command reusing a built-in type name - redeclaration of a type name, whether by the same or different metatype - redeclaration of a command or event - collision of a type with implicit 'Kind' e