Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-08-01 Thread Samuel Thibault
Pavel Dovgalyuk, le mar. 31 juil. 2018 09:58:26 +0300, a ecrit: > > From: Samuel Thibault [mailto:samuel.thiba...@gnu.org] > > Pavel Dovgalyuk, le jeu. 26 juil. 2018 11:37:57 +0300, a ecrit: > > > Or the timers are related to the network devices (e.g., servers in the > > > outer world)? > > > > No

Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-30 Thread Pavel Dovgalyuk
> From: Samuel Thibault [mailto:samuel.thiba...@gnu.org] > Pavel Dovgalyuk, le jeu. 26 juil. 2018 11:37:57 +0300, a ecrit: > > > From: Samuel Thibault [mailto:samuel.thiba...@gnu.org] > > > Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit: > > > > virtual clock should be used by the v

Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-26 Thread Samuel Thibault
Pavel Dovgalyuk, le jeu. 26 juil. 2018 11:37:57 +0300, a ecrit: > > From: Samuel Thibault [mailto:samuel.thiba...@gnu.org] > > Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit: > > > virtual clock should be used by the virtual devices. > > > slirp module is not the virtual device. The

Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-26 Thread Pavel Dovgalyuk
> From: Samuel Thibault [mailto:samuel.thiba...@gnu.org] > Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit: > > virtual clock should be used by the virtual devices. > > slirp module is not the virtual device. Therefore processed packets > > become visible to the guest after passing t

Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-26 Thread Samuel Thibault
Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit: > virtual clock should be used by the virtual devices. > slirp module is not the virtual device. Therefore processed packets > become visible to the guest after passing to the virtual network card. > Before that it can create any timer

Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-26 Thread Samuel Thibault
Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:37:03 +0300, a ecrit: > > From: Samuel Thibault [mailto:samuel.thiba...@gnu.org] > > Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit: > > > > As documented: > > > > > > > > * @QEMU_CLOCK_REALTIME: Real time clock > > > > * > > > > * The re

Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-26 Thread Pavel Dovgalyuk
> From: Samuel Thibault [mailto:samuel.thiba...@gnu.org] > Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit: > > > As documented: > > > > > > * @QEMU_CLOCK_REALTIME: Real time clock > > > * > > > * The real time clock should be used only for stuff which does not > > > * change the

Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-26 Thread Samuel Thibault
Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit: > > As documented: > > > > * @QEMU_CLOCK_REALTIME: Real time clock > > * > > * The real time clock should be used only for stuff which does not > > * change the virtual machine state, as it runs even if the virtual > > * machine

Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-26 Thread Pavel Dovgalyuk
> From: Samuel Thibault [mailto:samuel.thiba...@gnu.org] > Pavel Dovgalyuk, le mer. 25 juil. 2018 15:17:06 +0300, a ecrit: > > ICMP implementation for IPv6 uses timers based on virtual clock. > > This is incorrect because this service is not related to the guest state. > > ? Why not? The RAs are

Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-25 Thread Samuel Thibault
Pavel Dovgalyuk, le mer. 25 juil. 2018 15:17:06 +0300, a ecrit: > ICMP implementation for IPv6 uses timers based on virtual clock. > This is incorrect because this service is not related to the guest state. ? Why not? The RAs are seen by the guest. As documented: * @QEMU_CLOCK_REALTIME: Real t

[Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers

2018-07-25 Thread Pavel Dovgalyuk
ICMP implementation for IPv6 uses timers based on virtual clock. This is incorrect because this service is not related to the guest state. This patch changes using virtual clock to the realtime. Signed-off-by: Pavel Dovgalyuk --- slirp/ip6_icmp.c |6 +++--- 1 file changed, 3 insertions(+), 3