Re: [Qemu-devel] [PATCH v5 6/9] pci: Convert to realize

2017-06-19 Thread Mao Zhongyi
Hi, Marcel On 06/19/2017 07:42 PM, Marcel Apfelbaum wrote: On 12/06/2017 16:48, Mao Zhongyi wrote: The pci-birdge device i82801b11 It is a dmi-to-pci brigde and io3130_upstream/downstream You forgot to mention the pcie_root_port. still implements the old PCIDeviceClass .init() through

Re: [Qemu-devel] [PATCH v5 6/9] pci: Convert to realize

2017-06-19 Thread Marcel Apfelbaum
On 12/06/2017 16:48, Mao Zhongyi wrote: The pci-birdge device i82801b11 It is a dmi-to-pci brigde and io3130_upstream/downstream You forgot to mention the pcie_root_port. still implements the old PCIDeviceClass .init() through *_init() instead of the new .realize(). All devices need to

[Qemu-devel] [PATCH v5 6/9] pci: Convert to realize

2017-06-12 Thread Mao Zhongyi
The pci-birdge device i82801b11 and io3130_upstream/downstream still implements the old PCIDeviceClass .init() through *_init() instead of the new .realize(). All devices need to be converted to .realize(). So convert it and rename it to *_realize(). Cc: m...@redhat.com Cc: mar...@redhat.com Cc: