On Tue, 14 Nov 2017 10:34:01 +0800
Dou Liyang wrote:
> Linux and Windows need ACPI SRAT table to make memory hotplug work properly,
> however currently QEMU doesn't create SRAT table if numa options aren't
> present
> on CLI.
>
> Which breaks both linux and windows
On Wed, 15 Nov 2017 09:29:22 +0800
Dou Liyang wrote:
> Hi Igor,
>
> [...]
> >> +parse_numa_node(ms, , NULL);
> > I get build break here:
> >
> > numa.c:451:13: error: too few arguments to function ‘parse_numa_node’
> > parse_numa_node(ms, ,
Hi Igor,
[...]
+parse_numa_node(ms, , NULL);
I get build break here:
numa.c:451:13: error: too few arguments to function ‘parse_numa_node’
parse_numa_node(ms, , NULL);
In upstream tree, your commit
cc001888b780 ("numa: fixup parsed NumaNodeOptions earlier")
On Tue, 14 Nov 2017 10:34:01 +0800
Dou Liyang wrote:
> Linux and Windows need ACPI SRAT table to make memory hotplug work properly,
> however currently QEMU doesn't create SRAT table if numa options aren't
> present
> on CLI.
>
> Which breaks both linux and windows
Linux and Windows need ACPI SRAT table to make memory hotplug work properly,
however currently QEMU doesn't create SRAT table if numa options aren't present
on CLI.
Which breaks both linux and windows guests in certain conditions:
* Windows: won't enable memory hotplug without SRAT table at all