Re: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event instrumentation

2017-09-26 Thread Lluís Vilanova
Emilio G Cota writes: > On Mon, Sep 25, 2017 at 21:07:45 +0300, Lluís Vilanova wrote: >> You're doing it right, and I've checked that the branch is properly pushed. >> Can >> you compile with V=1 to show me the failing cmdline? > $ make V=1 > (cd /data/src/qemu2; printf '#define QEMU_PKGVERSION

Re: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event instrumentation

2017-09-25 Thread Emilio G. Cota
On Mon, Sep 25, 2017 at 21:07:45 +0300, Lluís Vilanova wrote: > You're doing it right, and I've checked that the branch is properly pushed. > Can > you compile with V=1 to show me the failing cmdline? $ make V=1 (cd /data/src/qemu2; printf '#define QEMU_PKGVERSION '; if test -n ""; then printf '

Re: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event instrumentation

2017-09-25 Thread Lluís Vilanova
Emilio G Cota writes: > On Wed, Sep 13, 2017 at 12:53:43 +0300, Lluís Vilanova wrote: >> The instrumentation code is dynamically loaded as a library into QEMU either >> when it starts or later using its remote control interfaces. The loaded code >> only has access to function explicitly exported t

Re: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event instrumentation

2017-09-25 Thread Emilio G. Cota
On Wed, Sep 13, 2017 at 12:53:43 +0300, Lluís Vilanova wrote: > The instrumentation code is dynamically loaded as a library into QEMU either > when it starts or later using its remote control interfaces. The loaded code > only has access to function explicitly exported through the QI_VPUBLIC macro.

Re: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event instrumentation

2017-09-13 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event instrumentation Message-id: 150529642278.10902.18234057937634437857.st...@frigg.lan Type: series === TEST SCRIPT BEGIN === #!/bin

[Qemu-devel] [PATCH v6 00/22] instrument: Add basic event instrumentation

2017-09-13 Thread Lluís Vilanova
This series adds an API to add instrumentation events. It also provides additional APIs for: * Controlling tracing events. * Peek/poke guest memory. TODO: * Replace qi_event_gen_* with generating calls to arbitrary functions (e.g., qi_event_gen_call(num_args, va_list)). * Flush all TBs when an