Re: [Qemu-devel] [PATCH v6 01/18] block: ensure bdrv_drain_all() works during bdrv_delete()

2013-08-07 Thread Stefan Hajnoczi
On Wed, Aug 07, 2013 at 10:42:26AM +0800, Wenchao Xia wrote: On Fri, Jul 26, 2013 at 02:43:44PM +0800, Wenchao Xia wrote: Reviewed-by: Wenchao Xia xiaw...@linux.vnet.ibm.com One question: old code missed itself in bdrv_drain_all(), is that a bug? Sorry, I don't understand the question.

Re: [Qemu-devel] [PATCH v6 01/18] block: ensure bdrv_drain_all() works during bdrv_delete()

2013-08-07 Thread Stefan Hajnoczi
On Thu, Jul 25, 2013 at 05:18:08PM +0200, Stefan Hajnoczi wrote: In bdrv_delete() make sure to call bdrv_make_anon() *after* bdrv_close() so that the device is still seen by bdrv_drain_all() when iterating bdrv_states. Cc: qemu-sta...@nongnu.org Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v6 01/18] block: ensure bdrv_drain_all() works during bdrv_delete()

2013-08-06 Thread Stefan Hajnoczi
On Fri, Jul 26, 2013 at 02:43:44PM +0800, Wenchao Xia wrote: Reviewed-by: Wenchao Xia xiaw...@linux.vnet.ibm.com One question: old code missed itself in bdrv_drain_all(), is that a bug? Sorry, I don't understand the question. Can you rephrase it? In bdrv_delete() make sure to call

Re: [Qemu-devel] [PATCH v6 01/18] block: ensure bdrv_drain_all() works during bdrv_delete()

2013-08-06 Thread Wenchao Xia
On Fri, Jul 26, 2013 at 02:43:44PM +0800, Wenchao Xia wrote: Reviewed-by: Wenchao Xia xiaw...@linux.vnet.ibm.com One question: old code missed itself in bdrv_drain_all(), is that a bug? Sorry, I don't understand the question. Can you rephrase it? Before this patch, in the code path:

Re: [Qemu-devel] [PATCH v6 01/18] block: ensure bdrv_drain_all() works during bdrv_delete()

2013-07-26 Thread Wenchao Xia
Reviewed-by: Wenchao Xia xiaw...@linux.vnet.ibm.com One question: old code missed itself in bdrv_drain_all(), is that a bug? In bdrv_delete() make sure to call bdrv_make_anon() *after* bdrv_close() so that the device is still seen by bdrv_drain_all() when iterating bdrv_states. Cc:

[Qemu-devel] [PATCH v6 01/18] block: ensure bdrv_drain_all() works during bdrv_delete()

2013-07-25 Thread Stefan Hajnoczi
In bdrv_delete() make sure to call bdrv_make_anon() *after* bdrv_close() so that the device is still seen by bdrv_drain_all() when iterating bdrv_states. Cc: qemu-sta...@nongnu.org Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2