Re: [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

2018-01-09 Thread Thomas Huth
On 09.01.2018 01:32, Alistair Francis wrote: > On Tue, Jan 2, 2018 at 4:59 AM, Markus Armbruster wrote: >> Alistair Francis writes: >> >>> On Fri, Dec 22, 2017 at 12:30 PM, Markus Armbruster >>> wrote: Alistair Francis writes: > On Fri, Dec 22, 2017 at 9:17 AM, Thomas Huth wrote

Re: [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

2018-01-08 Thread Alistair Francis
On Tue, Jan 2, 2018 at 4:59 AM, Markus Armbruster wrote: > Alistair Francis writes: > >> On Fri, Dec 22, 2017 at 12:30 PM, Markus Armbruster >> wrote: >>> Alistair Francis writes: >>> On Fri, Dec 22, 2017 at 9:17 AM, Thomas Huth wrote: > On 22.12.2017 16:37, Markus Armbruster wrote:

Re: [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

2018-01-02 Thread Markus Armbruster
Alistair Francis writes: > On Fri, Dec 22, 2017 at 12:30 PM, Markus Armbruster wrote: >> Alistair Francis writes: >> >>> On Fri, Dec 22, 2017 at 9:17 AM, Thomas Huth wrote: On 22.12.2017 16:37, Markus Armbruster wrote: > Second thoughts... > > Alistair Francis writes: [.

Re: [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

2017-12-22 Thread Alistair Francis
On Fri, Dec 22, 2017 at 12:30 PM, Markus Armbruster wrote: > Alistair Francis writes: > >> On Fri, Dec 22, 2017 at 9:17 AM, Thomas Huth wrote: >>> On 22.12.2017 16:37, Markus Armbruster wrote: Second thoughts... Alistair Francis writes: >>> [...] > #include "qemu/osdep.h" >>

Re: [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

2017-12-22 Thread Markus Armbruster
Alistair Francis writes: > On Fri, Dec 22, 2017 at 9:17 AM, Thomas Huth wrote: >> On 22.12.2017 16:37, Markus Armbruster wrote: >>> Second thoughts... >>> >>> Alistair Francis writes: >> [...] #include "qemu/osdep.h" +#include "qemu/error-report.h" #include "qapi/error.h"

Re: [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

2017-12-22 Thread Alistair Francis
On Fri, Dec 22, 2017 at 9:17 AM, Thomas Huth wrote: > On 22.12.2017 16:37, Markus Armbruster wrote: >> Second thoughts... >> >> Alistair Francis writes: > [...] >>> #include "qemu/osdep.h" >>> +#include "qemu/error-report.h" >>> #include "qapi/error.h" >>> #include "qemu-common.h" >>> #includ

Re: [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

2017-12-22 Thread Thomas Huth
On 22.12.2017 16:37, Markus Armbruster wrote: > Second thoughts... > > Alistair Francis writes: [...] >> #include "qemu/osdep.h" >> +#include "qemu/error-report.h" >> #include "qapi/error.h" >> #include "qemu-common.h" >> #include "cpu.h" >> @@ -1311,8 +1312,8 @@ static void omap_prcm_apll_up

Re: [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

2017-12-22 Thread Markus Armbruster
Second thoughts... Alistair Francis writes: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fp

Re: [Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

2017-12-22 Thread Markus Armbruster
Alistair Francis writes: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. > > find ./* -type f -exec sed -i \ > 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, > "\(

[Qemu-devel] [PATCH v6 04/29] hw/arm: Replace fprintf(stderr, "*\n" with error_report()

2017-12-20 Thread Alistair Francis
Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|I