Re: [Qemu-devel] [PATCH v6 06/12] nbd/server: Refactor zero-length option check

2017-10-30 Thread Eric Blake
On 10/30/2017 09:11 PM, Eric Blake wrote: > On 10/30/2017 06:22 PM, Vladimir Sementsov-Ogievskiy wrote: >> 27.10.2017 13:40, Eric Blake wrote: >>> Consolidate the response for a non-zero-length option payload >>> into a new function, nbd_reject_length().  This check will >>> also be used when

Re: [Qemu-devel] [PATCH v6 06/12] nbd/server: Refactor zero-length option check

2017-10-30 Thread Eric Blake
On 10/30/2017 06:22 PM, Vladimir Sementsov-Ogievskiy wrote: > 27.10.2017 13:40, Eric Blake wrote: >> Consolidate the response for a non-zero-length option payload >> into a new function, nbd_reject_length().  This check will >> also be used when introducing support for structured replies. >> >>

Re: [Qemu-devel] [PATCH v6 06/12] nbd/server: Refactor zero-length option check

2017-10-30 Thread Vladimir Sementsov-Ogievskiy
27.10.2017 13:40, Eric Blake wrote: Consolidate the response for a non-zero-length option payload into a new function, nbd_reject_length(). This check will also be used when introducing support for structured replies. Note that STARTTLS response differs based on time: if the connection is

[Qemu-devel] [PATCH v6 06/12] nbd/server: Refactor zero-length option check

2017-10-27 Thread Eric Blake
Consolidate the response for a non-zero-length option payload into a new function, nbd_reject_length(). This check will also be used when introducing support for structured replies. Note that STARTTLS response differs based on time: if the connection is still unencrypted, we set fatal to true (a