Re: [Qemu-devel] [PATCH v6 06/18] aio: stop using .io_flush()

2013-07-29 Thread Stefan Hajnoczi
On Mon, Jul 29, 2013 at 04:08:34PM +0800, Wenchao Xia wrote: > > Now that aio_poll() users check their termination condition themselves, > > it is no longer necessary to call .io_flush() handlers. > > > > The behavior of aio_poll() changes as follows: > > > > 1. .io_flush() is no longer invoked a

Re: [Qemu-devel] [PATCH v6 06/18] aio: stop using .io_flush()

2013-07-29 Thread Wenchao Xia
> Now that aio_poll() users check their termination condition themselves, > it is no longer necessary to call .io_flush() handlers. > > The behavior of aio_poll() changes as follows: > > 1. .io_flush() is no longer invoked and file descriptors are *always* > monitored. Previously returning 0 fro

Re: [Qemu-devel] [PATCH v6 06/18] aio: stop using .io_flush()

2013-07-26 Thread Jeff Cody
On Thu, Jul 25, 2013 at 05:18:13PM +0200, Stefan Hajnoczi wrote: > Now that aio_poll() users check their termination condition themselves, > it is no longer necessary to call .io_flush() handlers. > > The behavior of aio_poll() changes as follows: > > 1. .io_flush() is no longer invoked and file

Re: [Qemu-devel] [PATCH v6 06/18] aio: stop using .io_flush()

2013-07-26 Thread Jeff Cody
On Fri, Jul 26, 2013 at 06:25:18PM +0200, Paolo Bonzini wrote: > Il 26/07/2013 18:10, Jeff Cody ha scritto: > > + /* wait until next event that is not aio_notify() */ > > + while (count > 1) { > > > > This would assume of course that aio_notify() is always first in the > > list. > > No, you c

Re: [Qemu-devel] [PATCH v6 06/18] aio: stop using .io_flush()

2013-07-26 Thread Paolo Bonzini
Il 26/07/2013 18:10, Jeff Cody ha scritto: > + /* wait until next event that is not aio_notify() */ > + while (count > 1) { > > This would assume of course that aio_notify() is always first in the > list. No, you cannot assume that. Any bdrv can be opened early (with -drive) and then associa

Re: [Qemu-devel] [PATCH v6 06/18] aio: stop using .io_flush()

2013-07-26 Thread Jeff Cody
On Thu, Jul 25, 2013 at 05:18:13PM +0200, Stefan Hajnoczi wrote: > Now that aio_poll() users check their termination condition themselves, > it is no longer necessary to call .io_flush() handlers. > > The behavior of aio_poll() changes as follows: > > 1. .io_flush() is no longer invoked and file

[Qemu-devel] [PATCH v6 06/18] aio: stop using .io_flush()

2013-07-25 Thread Stefan Hajnoczi
Now that aio_poll() users check their termination condition themselves, it is no longer necessary to call .io_flush() handlers. The behavior of aio_poll() changes as follows: 1. .io_flush() is no longer invoked and file descriptors are *always* monitored. Previously returning 0 from .io_flush()