Re: [Qemu-devel] [PATCH v6 07/15] qapi: add #if/#endif helpers

2018-07-03 Thread Marc-André Lureau
Hi On Tue, Jul 3, 2018 at 5:34 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Hi >> >> On Tue, Jul 3, 2018 at 3:37 PM, Markus Armbruster wrote: >>> Marc-André Lureau writes: >>> Hi On Tue, Jul 3, 2018 at 1:53 PM, Markus Armbruster wrote: > Marc-André Lu

Re: [Qemu-devel] [PATCH v6 07/15] qapi: add #if/#endif helpers

2018-07-03 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Jul 3, 2018 at 3:37 PM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> Hi >>> >>> On Tue, Jul 3, 2018 at 1:53 PM, Markus Armbruster wrote: Marc-André Lureau writes: > Add helpers to wrap generated code with #if/#endif line

Re: [Qemu-devel] [PATCH v6 07/15] qapi: add #if/#endif helpers

2018-07-03 Thread Marc-André Lureau
Hi On Tue, Jul 3, 2018 at 3:37 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Hi >> >> On Tue, Jul 3, 2018 at 1:53 PM, Markus Armbruster wrote: >>> Marc-André Lureau writes: >>> Add helpers to wrap generated code with #if/#endif lines. Add QAPIGenCSnippet class to

Re: [Qemu-devel] [PATCH v6 07/15] qapi: add #if/#endif helpers

2018-07-03 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Jul 3, 2018 at 1:53 PM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> Add helpers to wrap generated code with #if/#endif lines. >>> >>> Add QAPIGenCSnippet class to write C snippet code, make QAPIGenC >>> inherit from it, for full C file

Re: [Qemu-devel] [PATCH v6 07/15] qapi: add #if/#endif helpers

2018-07-03 Thread Marc-André Lureau
Hi On Tue, Jul 3, 2018 at 1:53 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Add helpers to wrap generated code with #if/#endif lines. >> >> Add QAPIGenCSnippet class to write C snippet code, make QAPIGenC >> inherit from it, for full C files with copyright headers etc. > > It's

Re: [Qemu-devel] [PATCH v6 07/15] qapi: add #if/#endif helpers

2018-07-03 Thread Markus Armbruster
Marc-André Lureau writes: > Add helpers to wrap generated code with #if/#endif lines. > > Add QAPIGenCSnippet class to write C snippet code, make QAPIGenC > inherit from it, for full C files with copyright headers etc. It's called QAPIGenCCode now. Can touch up when I apply, along with another

[Qemu-devel] [PATCH v6 07/15] qapi: add #if/#endif helpers

2018-06-27 Thread Marc-André Lureau
Add helpers to wrap generated code with #if/#endif lines. Add QAPIGenCSnippet class to write C snippet code, make QAPIGenC inherit from it, for full C files with copyright headers etc. Add a 'with' statement context manager that will be used to wrap generator visitor methods. The manager will ch