Re: [Qemu-devel] [PATCH v6 1/3] qemu-nbd: add support for authorization of TLS clients

2019-02-28 Thread Eric Blake
On 2/28/19 12:18 PM, Daniel P. Berrangé wrote: >> It doesn't hold up this patch, but I note that with the qemu QMP command >> changes you make in 2/3, you document that the object can be >> created/removed on the fly, and the server will adjust which clients can >> then subsequently connect. Is th

Re: [Qemu-devel] [PATCH v6 1/3] qemu-nbd: add support for authorization of TLS clients

2019-02-28 Thread Eric Blake
On 2/27/19 10:43 AM, Eric Blake wrote: >> @example >> qemu-nbd \ >>--object tls-creds-x509,id=tls0,endpoint=server,dir=/path/to/qemutls \ >> - --tls-creds tls0 -t -x subset -p 10810 \ >> + --object 'authz-simple,id=auth0,identity=CN=laptop.example.com,,\ >> +O=Example Org,,L=Lo

Re: [Qemu-devel] [PATCH v6 1/3] qemu-nbd: add support for authorization of TLS clients

2019-02-28 Thread Daniel P . Berrangé
On Thu, Feb 28, 2019 at 12:11:00PM -0600, Eric Blake wrote: > On 2/27/19 10:20 AM, Daniel P. Berrangé wrote: > > From: "Daniel P. Berrange" > > > > Currently any client which can complete the TLS handshake is able to use > > the NBD server. The server admin can turn on the 'verify-peer' option >

Re: [Qemu-devel] [PATCH v6 1/3] qemu-nbd: add support for authorization of TLS clients

2019-02-28 Thread Eric Blake
On 2/27/19 10:20 AM, Daniel P. Berrangé wrote: > From: "Daniel P. Berrange" > > Currently any client which can complete the TLS handshake is able to use > the NBD server. The server admin can turn on the 'verify-peer' option > for the x509 creds to require the client to provide a x509 certificate

Re: [Qemu-devel] [PATCH v6 1/3] qemu-nbd: add support for authorization of TLS clients

2019-02-27 Thread Daniel P . Berrangé
On Wed, Feb 27, 2019 at 10:43:40AM -0600, Eric Blake wrote: > On 2/27/19 10:20 AM, Daniel P. Berrangé wrote: > > From: "Daniel P. Berrange" > > > > Currently any client which can complete the TLS handshake is able to use > > the NBD server. The server admin can turn on the 'verify-peer' option >

Re: [Qemu-devel] [PATCH v6 1/3] qemu-nbd: add support for authorization of TLS clients

2019-02-27 Thread Eric Blake
On 2/27/19 10:20 AM, Daniel P. Berrangé wrote: > From: "Daniel P. Berrange" > > Currently any client which can complete the TLS handshake is able to use > the NBD server. The server admin can turn on the 'verify-peer' option > for the x509 creds to require the client to provide a x509 certificate

[Qemu-devel] [PATCH v6 1/3] qemu-nbd: add support for authorization of TLS clients

2019-02-27 Thread Daniel P . Berrangé
From: "Daniel P. Berrange" Currently any client which can complete the TLS handshake is able to use the NBD server. The server admin can turn on the 'verify-peer' option for the x509 creds to require the client to provide a x509 certificate. This means the client will have to acquire a certificat