Re: [Qemu-devel] [PATCH v6 12/12] virtio-blk: add x-data-plane=on|off performance feature

2012-12-19 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Tue, Dec 18, 2012 at 03:57:17PM +0100, Stefan Hajnoczi wrote: >> > > @@ -407,6 +409,14 @@ static void virtio_blk_handle_output(VirtIODevice >> > > *vdev, VirtQueue *vq) >> > > .num_writes = 0, >> > > }; >> > > >> > > +/* Some guests kick befor

Re: [Qemu-devel] [PATCH v6 12/12] virtio-blk: add x-data-plane=on|off performance feature

2012-12-18 Thread Michael S. Tsirkin
On Tue, Dec 18, 2012 at 03:57:17PM +0100, Stefan Hajnoczi wrote: > > > @@ -407,6 +409,14 @@ static void virtio_blk_handle_output(VirtIODevice > > > *vdev, VirtQueue *vq) > > > .num_writes = 0, > > > }; > > > > > > +/* Some guests kick before setting VIRTIO_CONFIG_S_DRIVER_OK so

Re: [Qemu-devel] [PATCH v6 12/12] virtio-blk: add x-data-plane=on|off performance feature

2012-12-18 Thread Stefan Hajnoczi
On Sun, Dec 16, 2012 at 06:08:53PM +0200, Michael S. Tsirkin wrote: > On Mon, Dec 10, 2012 at 02:09:45PM +0100, Stefan Hajnoczi wrote: > > @@ -33,6 +34,7 @@ typedef struct VirtIOBlock > > VirtIOBlkConf *blk; > > unsigned short sector_mask; > > DeviceState *qdev; > > +VirtIOBlockD

Re: [Qemu-devel] [PATCH v6 12/12] virtio-blk: add x-data-plane=on|off performance feature

2012-12-16 Thread Michael S. Tsirkin
On Mon, Dec 10, 2012 at 02:09:45PM +0100, Stefan Hajnoczi wrote: > @@ -33,6 +34,7 @@ typedef struct VirtIOBlock > VirtIOBlkConf *blk; > unsigned short sector_mask; > DeviceState *qdev; > +VirtIOBlockDataPlane *dataplane; > } VirtIOBlock; > > static VirtIOBlock *to_virtio_blk(

[Qemu-devel] [PATCH v6 12/12] virtio-blk: add x-data-plane=on|off performance feature

2012-12-10 Thread Stefan Hajnoczi
The virtio-blk-data-plane feature is easy to integrate into hw/virtio-blk.c. The data plane can be started and stopped similar to vhost-net. Users can take advantage of the virtio-blk-data-plane feature using the new -device virtio-blk-pci,x-data-plane=on property. The x-data-plane name was chos