Re: [Qemu-devel] [PATCH v6 14/16] qapi: Consistent generated code: minimize push_indent() usage

2015-10-01 Thread Markus Armbruster
Eric Blake writes: > On 09/29/2015 08:10 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> We had some pointless differences in the generated code for visit, >>> command marshalling, and events; unifying them makes it easier for >>> future patches to consolidate to common helper functio

Re: [Qemu-devel] [PATCH v6 14/16] qapi: Consistent generated code: minimize push_indent() usage

2015-09-30 Thread Eric Blake
On 09/29/2015 08:10 AM, Markus Armbruster wrote: > Eric Blake writes: > >> We had some pointless differences in the generated code for visit, >> command marshalling, and events; unifying them makes it easier for >> future patches to consolidate to common helper functions. >> >> This patch makes n

Re: [Qemu-devel] [PATCH v6 14/16] qapi: Consistent generated code: minimize push_indent() usage

2015-09-30 Thread Markus Armbruster
Eric Blake writes: > We had some pointless differences in the generated code for visit, > command marshalling, and events; unifying them makes it easier for > future patches to consolidate to common helper functions. > > This patch makes no difference to the generated code, but rather > focuses o

[Qemu-devel] [PATCH v6 14/16] qapi: Consistent generated code: minimize push_indent() usage

2015-09-28 Thread Eric Blake
We had some pointless differences in the generated code for visit, command marshalling, and events; unifying them makes it easier for future patches to consolidate to common helper functions. This patch makes no difference to the generated code, but rather focuses on reducing the number of push_in