Re: [Qemu-devel] [PATCH v6 16/17] net: Introduce e1000e device emulation

2016-05-31 Thread Dmitry Fleytman
> On 31 May 2016, at 09:08 AM, Dmitry Fleytman wrote: > > >> On 30 May 2016, at 18:10 PM, Michael S. Tsirkin wrote: >> >> On Mon, May 30, 2016 at 12:14:41PM +0300, Leonid Bloch wrote: >>> diff --git a/hw/net/e1000e.c b/hw/net/e1000e.c >>> new file mode

Re: [Qemu-devel] [PATCH v6 16/17] net: Introduce e1000e device emulation

2016-05-31 Thread Dmitry Fleytman
> On 30 May 2016, at 18:10 PM, Michael S. Tsirkin wrote: > > On Mon, May 30, 2016 at 12:14:41PM +0300, Leonid Bloch wrote: >> diff --git a/hw/net/e1000e.c b/hw/net/e1000e.c >> new file mode 100644 >> index 000..4da6bb1 >> --- /dev/null >> +++ b/hw/net/e1000e.c > > Here are

Re: [Qemu-devel] [PATCH v6 16/17] net: Introduce e1000e device emulation

2016-05-30 Thread Michael S. Tsirkin
On Mon, May 30, 2016 at 12:14:41PM +0300, Leonid Bloch wrote: > diff --git a/hw/net/e1000e.c b/hw/net/e1000e.c > new file mode 100644 > index 000..4da6bb1 > --- /dev/null > +++ b/hw/net/e1000e.c Here are minor style issues that can be fixed after this is upstream. See below. > @@ -0,0 +1,739