Re: [Qemu-devel] [PATCH v6 18/27] qapi: add an error in case a discriminator is conditionnal

2018-12-10 Thread Marc-André Lureau
Hi On Thu, Dec 6, 2018 at 8:25 PM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > Making a discriminator conditonal doesn't make much sense. > > Good point (so easy to overlook!), but why first add the 'if' feature > broken that way in PATCH 16, then fix it up in PATCH 18? Not

Re: [Qemu-devel] [PATCH v6 18/27] qapi: add an error in case a discriminator is conditionnal

2018-12-06 Thread Markus Armbruster
One more thing: in the subject, s/conditionnal/conditional/.

Re: [Qemu-devel] [PATCH v6 18/27] qapi: add an error in case a discriminator is conditionnal

2018-12-06 Thread Markus Armbruster
Marc-André Lureau writes: > Making a discriminator conditonal doesn't make much sense. Good point (so easy to overlook!), but why first add the 'if' feature broken that way in PATCH 16, then fix it up in PATCH 18? >Instead, > the

[Qemu-devel] [PATCH v6 18/27] qapi: add an error in case a discriminator is conditionnal

2018-07-06 Thread Marc-André Lureau
Making a discriminator conditonal doesn't make much sense. Instead, the union could be made conditional. Signed-off-by: Marc-André Lureau --- scripts/qapi/common.py | 11 +-- tests/Makefile.include | 1 +