Re: [Qemu-devel] [PATCH v6 2/2] qdisk - hw/block/xen_disk: grant copy implementation

2016-09-12 Thread Roger Pau Monné
On Wed, Sep 07, 2016 at 12:41:00PM +0200, Paulina Szubarczyk wrote: > Copy data operated on during request from/to local buffers to/from > the grant references. > > Before grant copy operation local buffers must be allocated what is > done by calling ioreq_init_copy_buffers. For the 'read' operati

Re: [Qemu-devel] [PATCH v6 2/2] qdisk - hw/block/xen_disk: grant copy implementation

2016-09-09 Thread Paulina Szubarczyk
On 09/08/2016 12:00 AM, Paulina Szubarczyk wrote: On 09/07/2016 10:56 PM, Stefano Stabellini wrote: On Wed, 7 Sep 2016, Paulina Szubarczyk wrote: Copy data operated on during request from/to local buffers to/from the grant references. Before grant copy operation local buffers must be alloca

Re: [Qemu-devel] [PATCH v6 2/2] qdisk - hw/block/xen_disk: grant copy implementation

2016-09-08 Thread Stefano Stabellini
On Thu, 8 Sep 2016, Paulina Szubarczyk wrote: > > > @@ -582,6 +722,9 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq) > > > } > > > default: > > > /* unknown operation (shouldn't happen -- parse catches this) */ > > > +if (!ioreq->blkdev->feature_grant_copy) { >

Re: [Qemu-devel] [PATCH v6 2/2] qdisk - hw/block/xen_disk: grant copy implementation

2016-09-07 Thread Paulina Szubarczyk
On 09/07/2016 10:56 PM, Stefano Stabellini wrote: On Wed, 7 Sep 2016, Paulina Szubarczyk wrote: Copy data operated on during request from/to local buffers to/from the grant references. Before grant copy operation local buffers must be allocated what is done by calling ioreq_init_copy_buffers.

Re: [Qemu-devel] [PATCH v6 2/2] qdisk - hw/block/xen_disk: grant copy implementation

2016-09-07 Thread Stefano Stabellini
On Wed, 7 Sep 2016, Paulina Szubarczyk wrote: > Copy data operated on during request from/to local buffers to/from > the grant references. > > Before grant copy operation local buffers must be allocated what is > done by calling ioreq_init_copy_buffers. For the 'read' operation, > first, the qemu

Re: [Qemu-devel] [PATCH v6 2/2] qdisk - hw/block/xen_disk: grant copy implementation

2016-09-07 Thread Anthony PERARD
On Wed, Sep 07, 2016 at 12:41:00PM +0200, Paulina Szubarczyk wrote: > Copy data operated on during request from/to local buffers to/from > the grant references. > > Before grant copy operation local buffers must be allocated what is > done by calling ioreq_init_copy_buffers. For the 'read' operati

[Qemu-devel] [PATCH v6 2/2] qdisk - hw/block/xen_disk: grant copy implementation

2016-09-07 Thread Paulina Szubarczyk
Copy data operated on during request from/to local buffers to/from the grant references. Before grant copy operation local buffers must be allocated what is done by calling ioreq_init_copy_buffers. For the 'read' operation, first, the qemu device invokes the read operation on local buffers and on