Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2018-04-17 Thread Eduardo Habkost
On Tue, Apr 17, 2018 at 06:31:57PM -0400, Cole Robinson wrote: > On 04/17/2018 05:11 PM, Eduardo Habkost wrote: > > On Tue, Apr 17, 2018 at 03:12:03PM -0400, Cole Robinson wrote: > > [...] > >> Reviving this... did any follow up changes happen? > >> > >> Marc-André patched virt-manager a few months

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2018-04-17 Thread Cole Robinson
On 04/17/2018 05:11 PM, Eduardo Habkost wrote: > On Tue, Apr 17, 2018 at 03:12:03PM -0400, Cole Robinson wrote: > [...] >> Reviving this... did any follow up changes happen? >> >> Marc-André patched virt-manager a few months back to enable -device >> vmcoreinfo for new VMs: >> >> https://www.redhat

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2018-04-17 Thread Eduardo Habkost
On Tue, Apr 17, 2018 at 03:12:03PM -0400, Cole Robinson wrote: [...] > Reviving this... did any follow up changes happen? > > Marc-André patched virt-manager a few months back to enable -device > vmcoreinfo for new VMs: > > https://www.redhat.com/archives/virt-tools-list/2018-February/msg00020.ht

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2018-04-17 Thread Cole Robinson
On 10/20/2017 02:48 PM, Eduardo Habkost wrote: > On Sun, Oct 15, 2017 at 04:56:28AM +0300, Michael S. Tsirkin wrote: >> On Tue, Oct 10, 2017 at 03:01:10PM -0300, Eduardo Habkost wrote: >>> On Tue, Oct 10, 2017 at 04:06:28PM +0100, Daniel P. Berrange wrote: On Tue, Oct 10, 2017 at 05:00:18PM +0

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-20 Thread Eduardo Habkost
On Sun, Oct 15, 2017 at 04:56:28AM +0300, Michael S. Tsirkin wrote: > On Tue, Oct 10, 2017 at 03:01:10PM -0300, Eduardo Habkost wrote: > > On Tue, Oct 10, 2017 at 04:06:28PM +0100, Daniel P. Berrange wrote: > > > On Tue, Oct 10, 2017 at 05:00:18PM +0200, Marc-André Lureau wrote: > > > > Hi > > > >

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-14 Thread Michael S. Tsirkin
On Tue, Oct 10, 2017 at 03:01:10PM -0300, Eduardo Habkost wrote: > On Tue, Oct 10, 2017 at 04:06:28PM +0100, Daniel P. Berrange wrote: > > On Tue, Oct 10, 2017 at 05:00:18PM +0200, Marc-André Lureau wrote: > > > Hi > > > > > > On Tue, Oct 10, 2017 at 10:31 AM, Daniel P. Berrange > > > wrote: > >

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-14 Thread Michael S. Tsirkin
On Tue, Oct 10, 2017 at 03:01:10PM -0300, Eduardo Habkost wrote: > On Tue, Oct 10, 2017 at 04:06:28PM +0100, Daniel P. Berrange wrote: > > On Tue, Oct 10, 2017 at 05:00:18PM +0200, Marc-André Lureau wrote: > > > Hi > > > > > > On Tue, Oct 10, 2017 at 10:31 AM, Daniel P. Berrange > > > wrote: > >

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-10 Thread Eduardo Habkost
On Tue, Oct 10, 2017 at 12:44:26AM +0300, Michael S. Tsirkin wrote: > On Mon, Oct 09, 2017 at 02:02:18PM +0100, Daniel P. Berrange wrote: > > On Mon, Oct 09, 2017 at 02:43:44PM +0200, Igor Mammedov wrote: > > > On Mon, 9 Oct 2017 12:03:36 +0100 > > > "Daniel P. Berrange" wrote: > > > > > > > On M

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-10 Thread Eduardo Habkost
On Tue, Oct 10, 2017 at 04:06:28PM +0100, Daniel P. Berrange wrote: > On Tue, Oct 10, 2017 at 05:00:18PM +0200, Marc-André Lureau wrote: > > Hi > > > > On Tue, Oct 10, 2017 at 10:31 AM, Daniel P. Berrange > > wrote: > > > On Tue, Oct 10, 2017 at 12:44:26AM +0300, Michael S. Tsirkin wrote: > > >>

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-10 Thread Michael S. Tsirkin
On Tue, Oct 10, 2017 at 04:06:28PM +0100, Daniel P. Berrange wrote: > On Tue, Oct 10, 2017 at 05:00:18PM +0200, Marc-André Lureau wrote: > > Hi > > > > On Tue, Oct 10, 2017 at 10:31 AM, Daniel P. Berrange > > wrote: > > > On Tue, Oct 10, 2017 at 12:44:26AM +0300, Michael S. Tsirkin wrote: > > >>

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-10 Thread Daniel P. Berrange
On Tue, Oct 10, 2017 at 05:00:18PM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Oct 10, 2017 at 10:31 AM, Daniel P. Berrange > wrote: > > On Tue, Oct 10, 2017 at 12:44:26AM +0300, Michael S. Tsirkin wrote: > >> On Mon, Oct 09, 2017 at 02:02:18PM +0100, Daniel P. Berrange wrote: > >> > On Mon,

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-10 Thread Michael S. Tsirkin
On Tue, Oct 10, 2017 at 05:00:18PM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Oct 10, 2017 at 10:31 AM, Daniel P. Berrange > wrote: > > On Tue, Oct 10, 2017 at 12:44:26AM +0300, Michael S. Tsirkin wrote: > >> On Mon, Oct 09, 2017 at 02:02:18PM +0100, Daniel P. Berrange wrote: > >> > On Mon,

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-10 Thread Marc-André Lureau
Hi On Tue, Oct 10, 2017 at 10:31 AM, Daniel P. Berrange wrote: > On Tue, Oct 10, 2017 at 12:44:26AM +0300, Michael S. Tsirkin wrote: >> On Mon, Oct 09, 2017 at 02:02:18PM +0100, Daniel P. Berrange wrote: >> > On Mon, Oct 09, 2017 at 02:43:44PM +0200, Igor Mammedov wrote: >> > > On Mon, 9 Oct 2017

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-10 Thread Daniel P. Berrange
On Tue, Oct 10, 2017 at 12:44:26AM +0300, Michael S. Tsirkin wrote: > On Mon, Oct 09, 2017 at 02:02:18PM +0100, Daniel P. Berrange wrote: > > On Mon, Oct 09, 2017 at 02:43:44PM +0200, Igor Mammedov wrote: > > > On Mon, 9 Oct 2017 12:03:36 +0100 > > > "Daniel P. Berrange" wrote: > > > > > > > On M

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-09 Thread Michael S. Tsirkin
On Mon, Oct 09, 2017 at 02:02:18PM +0100, Daniel P. Berrange wrote: > On Mon, Oct 09, 2017 at 02:43:44PM +0200, Igor Mammedov wrote: > > On Mon, 9 Oct 2017 12:03:36 +0100 > > "Daniel P. Berrange" wrote: > > > > > On Mon, Sep 11, 2017 at 06:59:24PM +0200, Marc-André Lureau wrote: > > > > See docs/

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-09 Thread Daniel P. Berrange
On Mon, Oct 09, 2017 at 02:43:44PM +0200, Igor Mammedov wrote: > On Mon, 9 Oct 2017 12:03:36 +0100 > "Daniel P. Berrange" wrote: > > > On Mon, Sep 11, 2017 at 06:59:24PM +0200, Marc-André Lureau wrote: > > > See docs/specs/vmcoreinfo.txt for details. > > > > > > "etc/vmcoreinfo" fw_cfg entry is

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-09 Thread Igor Mammedov
On Mon, 9 Oct 2017 12:03:36 +0100 "Daniel P. Berrange" wrote: > On Mon, Sep 11, 2017 at 06:59:24PM +0200, Marc-André Lureau wrote: > > See docs/specs/vmcoreinfo.txt for details. > > > > "etc/vmcoreinfo" fw_cfg entry is added when using "-device vmcoreinfo". > > I'm wondering if you considered

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-09 Thread Marc-André Lureau
Hi - Original Message - > On Mon, Sep 11, 2017 at 06:59:24PM +0200, Marc-André Lureau wrote: > > See docs/specs/vmcoreinfo.txt for details. > > > > "etc/vmcoreinfo" fw_cfg entry is added when using "-device vmcoreinfo". > > I'm wondering if you considered just adding the entry to fw_cfg

Re: [Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-10-09 Thread Daniel P. Berrange
On Mon, Sep 11, 2017 at 06:59:24PM +0200, Marc-André Lureau wrote: > See docs/specs/vmcoreinfo.txt for details. > > "etc/vmcoreinfo" fw_cfg entry is added when using "-device vmcoreinfo". I'm wondering if you considered just adding the entry to fw_cfg by default, without requiring any -device arg

[Qemu-devel] [PATCH v6 2/7] hw/misc: add vmcoreinfo device

2017-09-11 Thread Marc-André Lureau
See docs/specs/vmcoreinfo.txt for details. "etc/vmcoreinfo" fw_cfg entry is added when using "-device vmcoreinfo". Signed-off-by: Marc-André Lureau --- include/hw/misc/vmcoreinfo.h | 46 + hw/misc/vmcoreinfo.c | 96 docs/s