Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-14 Thread KONRAD Frédéric
On 14/03/2013 09:42, Cornelia Huck wrote: On Thu, 14 Mar 2013 09:37:54 +0100 KONRAD Frédéric wrote: On 14/03/2013 08:25, Cornelia Huck wrote: On Wed, 13 Mar 2013 16:32:31 +0100 KONRAD Frédéric wrote: On 13/03/2013 09:24, KONRAD Frédéric wrote: On 12/03/2013 17:31, Cornelia Huck wrote: On

Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-14 Thread Cornelia Huck
On Thu, 14 Mar 2013 09:37:54 +0100 KONRAD Frédéric wrote: > On 14/03/2013 08:25, Cornelia Huck wrote: > > On Wed, 13 Mar 2013 16:32:31 +0100 > > KONRAD Frédéric wrote: > > > >> On 13/03/2013 09:24, KONRAD Frédéric wrote: > >>> On 12/03/2013 17:31, Cornelia Huck wrote: > On Tue, 12 Mar 2013

Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-14 Thread KONRAD Frédéric
On 14/03/2013 08:25, Cornelia Huck wrote: On Wed, 13 Mar 2013 16:32:31 +0100 KONRAD Frédéric wrote: On 13/03/2013 09:24, KONRAD Frédéric wrote: On 12/03/2013 17:31, Cornelia Huck wrote: On Tue, 12 Mar 2013 16:22:22 +0100 KONRAD Frédéric wrote: On 12/03/2013 16:12, Peter Maydell wrote: On

Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-14 Thread Cornelia Huck
On Wed, 13 Mar 2013 16:32:31 +0100 KONRAD Frédéric wrote: > On 13/03/2013 09:24, KONRAD Frédéric wrote: > > On 12/03/2013 17:31, Cornelia Huck wrote: > >> On Tue, 12 Mar 2013 16:22:22 +0100 > >> KONRAD Frédéric wrote: > >> > >>> On 12/03/2013 16:12, Peter Maydell wrote: > On 12 March 2013 1

Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-13 Thread KONRAD Frédéric
On 13/03/2013 09:24, KONRAD Frédéric wrote: On 12/03/2013 17:31, Cornelia Huck wrote: On Tue, 12 Mar 2013 16:22:22 +0100 KONRAD Frédéric wrote: On 12/03/2013 16:12, Peter Maydell wrote: On 12 March 2013 15:08, KONRAD Frédéric wrote: On 12/03/2013 15:42, Peter Maydell wrote: Yes, I see you

Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-13 Thread KONRAD Frédéric
On 12/03/2013 17:31, Cornelia Huck wrote: On Tue, 12 Mar 2013 16:22:22 +0100 KONRAD Frédéric wrote: On 12/03/2013 16:12, Peter Maydell wrote: On 12 March 2013 15:08, KONRAD Frédéric wrote: On 12/03/2013 15:42, Peter Maydell wrote: Yes, I see your problem there, but DEFINE_VIRTIO_BLK_SCSI_P

Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-12 Thread Cornelia Huck
On Tue, 12 Mar 2013 16:22:22 +0100 KONRAD Frédéric wrote: > On 12/03/2013 16:12, Peter Maydell wrote: > > On 12 March 2013 15:08, KONRAD Frédéric wrote: > >> On 12/03/2013 15:42, Peter Maydell wrote: > >>> Yes, I see your problem there, but DEFINE_VIRTIO_BLK_SCSI_PROPERTY > >>> and DEFINE_DATA_P

Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-12 Thread KONRAD Frédéric
On 12/03/2013 16:12, Peter Maydell wrote: On 12 March 2013 15:08, KONRAD Frédéric wrote: On 12/03/2013 15:42, Peter Maydell wrote: Yes, I see your problem there, but DEFINE_VIRTIO_BLK_SCSI_PROPERTY and DEFINE_DATA_PLANE_PROPERTIES are just convenience macros, not ones that are expected to be u

Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-12 Thread Peter Maydell
On 12 March 2013 15:08, KONRAD Frédéric wrote: > On 12/03/2013 15:42, Peter Maydell wrote: >> >> Yes, I see your problem there, but DEFINE_VIRTIO_BLK_SCSI_PROPERTY >> and DEFINE_DATA_PLANE_PROPERTIES are just convenience macros, not >> ones that are expected to be used by other code, right? So you

Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-12 Thread KONRAD Frédéric
On 12/03/2013 15:42, Peter Maydell wrote: On 12 March 2013 14:37, KONRAD Frédéric wrote: On 12/03/2013 15:28, Peter Maydell wrote: On 12 March 2013 09:22, wrote: /* The ID for virtio_block */ @@ -130,4 +134,28 @@ typedef struct VirtIOBlock { #define DEFINE_VIRTIO_BLK_FEATURES(_state,

Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-12 Thread Peter Maydell
On 12 March 2013 14:37, KONRAD Frédéric wrote: > On 12/03/2013 15:28, Peter Maydell wrote: >> >> On 12 March 2013 09:22, wrote: >>> >>> /* The ID for virtio_block */ >>> @@ -130,4 +134,28 @@ typedef struct VirtIOBlock { >>> #define DEFINE_VIRTIO_BLK_FEATURES(_state, _field) \ >>> D

Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-12 Thread KONRAD Frédéric
On 12/03/2013 15:28, Peter Maydell wrote: On 12 March 2013 09:22, wrote: /* The ID for virtio_block */ @@ -130,4 +134,28 @@ typedef struct VirtIOBlock { #define DEFINE_VIRTIO_BLK_FEATURES(_state, _field) \ DEFINE_VIRTIO_COMMON_FEATURES(_state, _field) +#ifdef CONFIG_VIRTIO_BLK_D

Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-12 Thread Peter Maydell
On 12 March 2013 09:22, wrote: > /* The ID for virtio_block */ > @@ -130,4 +134,28 @@ typedef struct VirtIOBlock { > #define DEFINE_VIRTIO_BLK_FEATURES(_state, _field) \ > DEFINE_VIRTIO_COMMON_FEATURES(_state, _field) > > +#ifdef CONFIG_VIRTIO_BLK_DATA_PLANE > +#define DEFINE_DATA_PLAN

[Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-12 Thread fred . konrad
From: KONRAD Frederic Create virtio-blk which extends virtio-device, so it can be connected on virtio-bus. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 98 ++--- hw/virtio-blk.h | 28 + hw/virtio-pci.c | 11 +-- 3