Re: [Qemu-devel] [PATCH v6 21/27] qapi: add #if conditions to generated code members

On Mon, Dec 10, 2018 at 2:11 PM Markus Armbruster wrote: > > Markus Armbruster writes: > > > Marc-André Lureau writes: > > > >> Hi > >> On Thu, Dec 6, 2018 at 9:42 PM Markus Armbruster wrote: > >>> > >>> Marc-André Lureau writes: > >>> > >>> > Wrap generated enum/struct members and code with

Re: [Qemu-devel] [PATCH v6 21/27] qapi: add #if conditions to generated code members

On Mon, Dec 10, 2018 at 2:11 PM Markus Armbruster wrote: > > Markus Armbruster writes: > > > Marc-André Lureau writes: > > > >> Hi > >> On Thu, Dec 6, 2018 at 9:42 PM Markus Armbruster wrote: > >>> > >>> Marc-André Lureau writes: > >>> > >>> > Wrap generated enum/struct members and code with

Re: [Qemu-devel] [PATCH v6 21/27] qapi: add #if conditions to generated code members

Markus Armbruster writes: > Marc-André Lureau writes: > >> Hi >> On Thu, Dec 6, 2018 at 9:42 PM Markus Armbruster wrote: >>> >>> Marc-André Lureau writes: >>> >>> > Wrap generated enum/struct members and code with #if/#endif, using the >>> >>> enum and struct members >> >> ok >> >>> >>> >

Re: [Qemu-devel] [PATCH v6 21/27] qapi: add #if conditions to generated code members

Marc-André Lureau writes: > Hi > On Thu, Dec 6, 2018 at 9:42 PM Markus Armbruster wrote: >> >> Marc-André Lureau writes: >> >> > Wrap generated enum/struct members and code with #if/#endif, using the >> >> enum and struct members > > ok > >> >> > .ifcond members added in the previous patches.

Re: [Qemu-devel] [PATCH v6 21/27] qapi: add #if conditions to generated code members

Hi On Thu, Dec 6, 2018 at 9:42 PM Markus Armbruster wrote: > > Marc-André Lureau writes: > > > Wrap generated enum/struct members and code with #if/#endif, using the > > enum and struct members ok > > > .ifcond members added in the previous patches. > > > > Some types generate both enum and

Re: [Qemu-devel] [PATCH v6 21/27] qapi: add #if conditions to generated code members

Marc-André Lureau writes: > Wrap generated enum/struct members and code with #if/#endif, using the enum and struct members > .ifcond members added in the previous patches. > > Some types generate both enum and struct members for example, so a > step-by-step is unnecessarily complicated to deal

[Qemu-devel] [PATCH v6 21/27] qapi: add #if conditions to generated code members

Wrap generated enum/struct members and code with #if/#endif, using the .ifcond members added in the previous patches. Some types generate both enum and struct members for example, so a step-by-step is unnecessarily complicated to deal with (it would easily generate invalid intermediary code).