Re: [Qemu-devel] [PATCH v6 3/7] trace: [tcg] Delay changes to dynamic state when translating

2017-01-13 Thread Lluís Vilanova
Paolo Bonzini writes: > On 12/01/2017 20:37, Lluís Vilanova wrote: >> Stefan Hajnoczi writes: >> >>> On Tue, Jan 10, 2017 at 05:31:37PM +0100, Paolo Bonzini wrote: On 09/01/2017 18:01, Stefan Hajnoczi wrote: > Or use a simpler scheme: > > struct CPUState { > ... > uint32

Re: [Qemu-devel] [PATCH v6 3/7] trace: [tcg] Delay changes to dynamic state when translating

2017-01-12 Thread Paolo Bonzini
On 12/01/2017 20:37, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > >> On Tue, Jan 10, 2017 at 05:31:37PM +0100, Paolo Bonzini wrote: >>> On 09/01/2017 18:01, Stefan Hajnoczi wrote: Or use a simpler scheme: struct CPUState { ... uint32_t dstate_update_count; >

Re: [Qemu-devel] [PATCH v6 3/7] trace: [tcg] Delay changes to dynamic state when translating

2017-01-12 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Tue, Jan 10, 2017 at 05:31:37PM +0100, Paolo Bonzini wrote: >> On 09/01/2017 18:01, Stefan Hajnoczi wrote: >> > Or use a simpler scheme: >> > >> > struct CPUState { >> > ... >> > uint32_t dstate_update_count; >> > }; >> > >> > In trace_event_set_vcpu_state_dy

Re: [Qemu-devel] [PATCH v6 3/7] trace: [tcg] Delay changes to dynamic state when translating

2017-01-11 Thread Stefan Hajnoczi
On Tue, Jan 10, 2017 at 05:31:37PM +0100, Paolo Bonzini wrote: > On 09/01/2017 18:01, Stefan Hajnoczi wrote: > > Or use a simpler scheme: > > > > struct CPUState { > > ... > > uint32_t dstate_update_count; > > }; > > > > In trace_event_set_vcpu_state_dynamic(): > > > > if (state) { >

Re: [Qemu-devel] [PATCH v6 3/7] trace: [tcg] Delay changes to dynamic state when translating

2017-01-10 Thread Paolo Bonzini
On 09/01/2017 18:01, Stefan Hajnoczi wrote: > Or use a simpler scheme: > > struct CPUState { > ... > uint32_t dstate_update_count; > }; > > In trace_event_set_vcpu_state_dynamic(): > > if (state) { > trace_events_enabled_count++; > set_bit(vcpu_id, vcpu->trace_dstat

Re: [Qemu-devel] [PATCH v6 3/7] trace: [tcg] Delay changes to dynamic state when translating

2017-01-10 Thread Stefan Hajnoczi
On Wed, Dec 28, 2016 at 07:41:10PM +0100, Lluís Vilanova wrote: > This keeps consistency across all decisions taken during translation > when the dynamic state of a vCPU is changed in the middle of translating > some guest code. > > Signed-off-by: Lluís Vilanova > --- > cpu-exec.c |

[Qemu-devel] [PATCH v6 3/7] trace: [tcg] Delay changes to dynamic state when translating

2016-12-28 Thread Lluís Vilanova
This keeps consistency across all decisions taken during translation when the dynamic state of a vCPU is changed in the middle of translating some guest code. Signed-off-by: Lluís Vilanova --- cpu-exec.c | 26 ++ include/qom/cpu.h |7 +++ qom/cp