Re: [Qemu-devel] [PATCH v6 4/7] RTC: Add divider reset support

2012-05-17 Thread Paolo Bonzini
Il 17/05/2012 04:28, Zhang, Yang Z ha scritto: > > +static int32_t divider_reset; This must be a variable inside RTCState. The remark about inlining rtc_set_offset applies here as well. Paolo > +static inline bool rtc_running(RTCState *s) > +{ > +return (!(s->cmos_data[RTC_REG_B] & REG_B_S

[Qemu-devel] [PATCH v6 4/7] RTC: Add divider reset support

2012-05-16 Thread Zhang, Yang Z
The first update cycle begins one - half seconds later when divider reset is removing. Signed-off-by: Yang Zhang --- hw/mc146818rtc.c | 46 -- 1 files changed, 40 insertions(+), 6 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index