Re: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names

2014-06-24 Thread Jeff Cody
On Thu, Jun 19, 2014 at 05:17:16PM +0800, Stefan Hajnoczi wrote: > On Tue, Jun 17, 2014 at 05:53:48PM -0400, Jeff Cody wrote: > > Changes from v5->v6: > > > > * Check for attempt to commit an image to itself (Eric) > > * Add a comment to the bdrv_find for block-commit, indicating > > that libvir

Re: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names

2014-06-24 Thread Benoît Canet
The Tuesday 24 Jun 2014 à 16:08:57 (+0200), Kevin Wolf wrote : > Am 24.06.2014 um 15:32 hat Jeff Cody geschrieben: > > On Tue, Jun 24, 2014 at 10:48:52AM +0800, Fam Zheng wrote: > > > On Mon, 06/23 21:08, Stefan Hajnoczi wrote: > > > > On Thu, Jun 19, 2014 at 12:26:00PM -0400, Jeff Cody wrote: > >

Re: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names

2014-06-24 Thread Kevin Wolf
Am 24.06.2014 um 15:32 hat Jeff Cody geschrieben: > On Tue, Jun 24, 2014 at 10:48:52AM +0800, Fam Zheng wrote: > > On Mon, 06/23 21:08, Stefan Hajnoczi wrote: > > > On Thu, Jun 19, 2014 at 12:26:00PM -0400, Jeff Cody wrote: > > > > On Thu, Jun 19, 2014 at 05:17:16PM +0800, Stefan Hajnoczi wrote: >

Re: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names

2014-06-24 Thread Jeff Cody
On Tue, Jun 24, 2014 at 10:48:52AM +0800, Fam Zheng wrote: > On Mon, 06/23 21:08, Stefan Hajnoczi wrote: > > On Thu, Jun 19, 2014 at 12:26:00PM -0400, Jeff Cody wrote: > > > On Thu, Jun 19, 2014 at 05:17:16PM +0800, Stefan Hajnoczi wrote: > > > > On Tue, Jun 17, 2014 at 05:53:48PM -0400, Jeff Cody

Re: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names

2014-06-24 Thread Kevin Wolf
Am 19.06.2014 um 18:49 hat Eric Blake geschrieben: > On 06/19/2014 10:26 AM, Jeff Cody wrote: > >> b. Is it a good idea to perform op blocker checks on the root node? > >>It's inconsistent with resize, snapshot-sync, etc. Permissions in > >>BDS graphs with multiple root nodes (e.g. guest d

Re: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names

2014-06-23 Thread Fam Zheng
On Mon, 06/23 21:08, Stefan Hajnoczi wrote: > On Thu, Jun 19, 2014 at 12:26:00PM -0400, Jeff Cody wrote: > > On Thu, Jun 19, 2014 at 05:17:16PM +0800, Stefan Hajnoczi wrote: > > > On Tue, Jun 17, 2014 at 05:53:48PM -0400, Jeff Cody wrote: > > > Let's discuss this topic in a sub-thread and figure ou

Re: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names

2014-06-23 Thread Benoît Canet
The Monday 23 Jun 2014 à 21:08:09 (+0800), Stefan Hajnoczi wrote : > On Thu, Jun 19, 2014 at 12:26:00PM -0400, Jeff Cody wrote: > > On Thu, Jun 19, 2014 at 05:17:16PM +0800, Stefan Hajnoczi wrote: > > > On Tue, Jun 17, 2014 at 05:53:48PM -0400, Jeff Cody wrote: > > > Let's discuss this topic in a s

Re: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names

2014-06-23 Thread Stefan Hajnoczi
On Thu, Jun 19, 2014 at 12:26:00PM -0400, Jeff Cody wrote: > On Thu, Jun 19, 2014 at 05:17:16PM +0800, Stefan Hajnoczi wrote: > > On Tue, Jun 17, 2014 at 05:53:48PM -0400, Jeff Cody wrote: > > Let's discuss this topic in a sub-thread and figure out what to do for > > QEMU 2.1. This is an important

Re: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names

2014-06-19 Thread Benoît Canet
The Thursday 19 Jun 2014 à 17:17:16 (+0800), Stefan Hajnoczi wrote : > On Tue, Jun 17, 2014 at 05:53:48PM -0400, Jeff Cody wrote: > > Changes from v5->v6: > > > > * Check for attempt to commit an image to itself (Eric) > > * Add a comment to the bdrv_find for block-commit, indicating > > that li

Re: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names

2014-06-19 Thread Eric Blake
On 06/19/2014 10:49 AM, Eric Blake wrote: > if qemu allows shared BDS, and I am able to open 'base' as a shared BDS > for both disks, then an attempt to block-commit img1 into base will be > blocked because base is still in use by img2. But as a management app, > I shouldn't be attempting that in

Re: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names

2014-06-19 Thread Eric Blake
On 06/19/2014 10:26 AM, Jeff Cody wrote: > Having said that, to be fair, the new QAPI command change-backing-file > does propagate this top-layer in-use flag semantic, but I would prefer > that patch to be dropped rather than not committing this series. Libvirt would prefer to have change-backing

Re: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names

2014-06-19 Thread Jeff Cody
On Thu, Jun 19, 2014 at 05:17:16PM +0800, Stefan Hajnoczi wrote: > On Tue, Jun 17, 2014 at 05:53:48PM -0400, Jeff Cody wrote: > > Changes from v5->v6: > > > > * Check for attempt to commit an image to itself (Eric) > > * Add a comment to the bdrv_find for block-commit, indicating > > that libvir

Re: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names

2014-06-19 Thread Stefan Hajnoczi
On Tue, Jun 17, 2014 at 05:53:48PM -0400, Jeff Cody wrote: > Changes from v5->v6: > > * Check for attempt to commit an image to itself (Eric) > * Add a comment to the bdrv_find for block-commit, indicating > that libvirt uses the error case for probing (Eric) > * Added Benoit's R-b's > > Change

[Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names

2014-06-17 Thread Jeff Cody
Changes from v5->v6: * Check for attempt to commit an image to itself (Eric) * Add a comment to the bdrv_find for block-commit, indicating that libvirt uses the error case for probing (Eric) * Added Benoit's R-b's Changes from v4->v5: * Rebased on master * Fixed commit log typos / stale paragr